In-place patch/revert #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mikaelho can you also extend the documentation so developers know how to use this feature? |
jirikuncar
reviewed
Mar 31, 2017
dictdiffer/__init__.py
Outdated
|
|
||
| :param diff_result: Changes returned by ``diff``. | ||
| :param destination: Structure to apply the changes to. | ||
| :param in_place: By default, destination dictionary is deep copied before applying the patch, and the copy is returned. Setting ``in_place=True`` means that patch will apply the changes directly to and return the destination structure. |
There was a problem hiding this comment.
Please break the lines so they are not longer then 79 chars. Thanks
* NEW Adds new option for patching and reverting patches in-place.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding an in-place patch/revert capability, i.e. option for performing these operations without copying the target structure.
This would be a useful performance optimization in some large-volume use cases. I also have a functional need of patching in place while recording all changes made to the structure.
Implemented as an additional, optional parameter to patch and revert.