Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

global: separate commands and output and [more] #23

Merged
merged 1 commit into from Feb 27, 2020

Conversation

fenekku
Copy link
Collaborator

@fenekku fenekku commented Feb 26, 2020

  • Separate commands to be entered (bash syntax to pop) and
    returned output (console syntax to be muted), so that commands can be
    copied via the clipboard icon directly. Closes Clipboard copy only commands聽#6
  • Removed permission configuration advanced example temporarily given it wasn't
    working.
  • Documented more details of the workflow:
    • how checking for running containers incurs a 30s delay
    • how server must be stopped and started whenever invenio.cfg is changed
  • Moved some small sections around for clarity and focus.
  • Did a pass at all syntax highlighting to make everything pop
    as much as possible (jsx doesn't work so broken js was used for jsx 馃し)

Easiest way to assess is by running it locally.

- Separate commands to be entered (`bash` syntax to pop) and
  returned output (`console` syntax to be muted), so that commands can be
  copied via the clipboard icon directly. Closes inveniosoftware#6
- Removed permission configuration advanced example temporarily given it wasn't
  working.
- Documented more details of the workflow:
    * how checking for running containers incurs a 30s delay
    * how server must be stopped and started whenever invenio.cfg is changed
- Moved some small sections around for clarity and focus.
- Did a pass at all syntax highlighting in develop/ to make everything pop
  as much as possible (jsx doesn't work so broken js was used for jsx 馃し)

## Change search results

Changing how your results are presented in the search page is also something quite common.

We are going to update the search result template so we can show more text in the result's description. Create a file called `ResultsItemTemplate.jsx` inside `assets/templates/search` folder and then edit it as below:

```console
```js
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jsx is not supported, so the closest to some highlighting we can get is js but it doesn't render quite properly because it's JSX (html tags, curly braces...)

@fenekku fenekku merged commit ce09fdc into inveniosoftware:master Feb 27, 2020
@fenekku fenekku deleted the 6_clipboard_copy_commmands branch February 27, 2020 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clipboard copy only commands
2 participants