utils: force_list roundtrip check #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* FIX Adds `tuples` to recogines types in `reverse_force_list` so it behaves correctly as an inverse fuction to `force_list`. Reviewed-by: Jiri Kuncar <jiri.kuncar@cern.ch> Signed-off-by: Jacopo Notarstefano <jacopo.notarstefano@gmail.com>
Signed-off-by: Jiri Kuncar <jiri.kuncar@cern.ch>
|
LGTM |
kaplun
reviewed
Sep 23, 2016
| * Jiri Kuncar <jiri.kuncar@cern.ch> | ||
| * Sami Hiltunen <sami.mikael.hiltunen@cern.ch> | ||
| * Samuele Kaplun <samuele.kaplun@cern.ch> | ||
| * Tibor Simko <tibor.simko@cern.ch> | ||
| * zazasa <salvatore.zaza@gmail.com> |
There was a problem hiding this comment.
This should be written Salvatore Zaza (from TIND).
There was a problem hiding this comment.
Well, this is his Git signature.
There was a problem hiding this comment.
K. In the past @tiborsimko was pinging developers to confirm this is how they want to be presented in the log.
I'll ping Salvatore 👍
There was a problem hiding this comment.
Not on gitter, yet.
@zazasa you might wish to update your git signature so that your name is well reflected in git logs and e.g. in AUTHORS.rst
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #149