tests: unicode all the way #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jirikuncar I've removed the culprit. Let me know what needs to be changed before you can consider merging it. Thanks! |
|
@greut can you check situation in which a field contains any html entity like
|
|
Added in the test suite: |
|
@greut |
| @@ -9,14 +9,13 @@ | |||
|
|
|||
| """Test suite for DoJSON.""" | |||
|
|
|||
| from __future__ import unicode_literals | |||
|
@jirikuncar m'kay. |
* BETTER Adds two records to be tested. * BETTER Reorders some of the assertion: `expected == actual`. Signed-off-by: Yoan Blanc <yoan@dosimple.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using utf-8 strings in the tests. It's easier to check that the output correspond when you don't have to match a character with it's html entity.
Remove some non used stuff and flake warnings.
And break the tests ;-)