Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

global: addition of cli command for schema validation #4

Merged
merged 1 commit into from Oct 12, 2016

Conversation

PaulinaLach
Copy link

  • NEW Adds a new command which validates schemas.
    Command comes with an '--ignore_indexes' option.

Signed-off-by: Paulina1 paulina.malgorzata.lach@cern.cech

def _warn_node(self, msg, *args, **kwargs):
"""Do not warn on external images."""
if not msg.startswith('nonlocal image URI found:'):
self._warnfunc(msg, '{0}:{1}'.format(get_source_line(node)))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was removed by the previous sphinx fix.

@nharraud nharraud added this to the v0.1.0 milestone Jun 7, 2016
@nharraud nharraud self-assigned this Jun 7, 2016

By default the index of "array" "items" are ignored. Thus all the values of
an array should have the same type in order to be compatible.
This behavior can be disabled by setting in constructor:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

by setting "ignore_index=False" in the validator's constructor.

# This file is part of DoMapping.
# Copyright (C) 2015, 2016 CERN.
#
# DoMapping is free software; you can redistribute it
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The project name is DoSchema, not DoMapping.

# -*- coding: utf-8 -*-
#
# This file is part of DoMapping.
# Copyright (C) 2015, 2016 CERN.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The project name is DoSchema, not DoMapping.
This file is created in 2016, no need to add 2015 in the copyright.

@coveralls
Copy link

coveralls commented Aug 22, 2016

Coverage Status

Coverage increased (+1.004%) to 90.26% when pulling dc74dfa on PaulinaLach:cli into e1ae7b7 on inveniosoftware:master.

@@ -28,6 +28,16 @@

import sphinx.environment

_warn_node_old = sphinx.environment.BuildEnvironment.warn_node
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you don't need it anymore. check latest cookiecutter-invenio-module (upgrade Sphinx).

* NEW Adds a new command which validates schemas.
  Command comes with an '--ignore_indexes' option.

Signed-off-by: PaulinaLach <paulina.malgorzata.lach@cern.ch>
@jirikuncar
Copy link
Member

jirikuncar commented Oct 12, 2016

@nharraud being part of @inveniosoftware/maintainers you should check commit message style before merging on Invenio software organization (1: M190 line is too long (53 > 50)).

@nharraud
Copy link
Member

@jirikuncar Sorry for that. Next time I will also run kwalitee before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants