Decrease celery minimal version #38
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* due to lack of msgpack support in 4.3
lnielsen
reviewed
Nov 28, 2019
| @@ -47,7 +47,7 @@ | |||
| install_requires = [ | |||
| 'Flask>=0.10', | |||
| 'celery>=3.1;python_version<"3.7"', | |||
| 'celery>=4.3;python_version=="3.7"', | |||
| 'celery>=4.2;python_version=="3.7"', | |||
There was a problem hiding this comment.
Celery 4.2 will not work on Python 3.7 due to the addition of the async keyword in Python AFAIR
There was a problem hiding this comment.
@kprzerwa Actually @lnielsen is correct, sorry for the false info. I think the reason tests are passing is because we're not testing with Redis as a storage backend, which would cause Python 3.7 to fail.
There was a problem hiding this comment.
I discussed also with @ntarocco and we decided to close this PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.