Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply black #54

Merged
merged 2 commits into from Apr 26, 2022
Merged

Apply black #54

merged 2 commits into from Apr 26, 2022

Conversation

utnapischtim
Copy link
Contributor

❤️ Thank you for your contribution!

Description

This PR migrates the whole repository to be formatted by black by applying following shell command to the whole repository:

find -name '*.py' -exec black {} \;

Further, the PR uses the .git-blame-ignore-revs file to ignore "apply black to the whole codebase" commit if git blame is used. It works also on github. As the introducing_black_to_your_project suggests i did also git config --global blame.ignoreRevsFile .git-blame-ignore-revs to ignore the commit on your pc. With --global it has to be done only once.

Also, the PR moved the pytest.ini to setup.cfg to make the setup.cfg the only configuration file wherever possible.

This PR uses pytest-black to check if black was used as the formatting tool. the --black was added to the addopts of the pytest configuration.

I would like to discuss with this commit whether we want to use pylint. I explicitly made the changes with a single commit so it's clear what changes are required for this repository.

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

Third-party code

If you've added third-party code (copy/pasted or new dependencies), please reach out to an architect.

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

  1. You license your contribution under the same terms as the current repository’s license.
  2. You agree that you have the right to license your contribution under the current repository’s license.

@lnielsen lnielsen merged commit 11d2d31 into inveniosoftware:master Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants