api: fix best fit for thumbnail, add background #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drjova
reviewed
May 14, 2018
| (200, 100), | ||
| (1280, 720), | ||
| ]) | ||
| def setUp(self, width=1280, height=1024): |
There was a problem hiding this comment.
since you parametrize it, could you please move the imports outside :)
from PIL import Image
from flask_iiif.api import MultimediaImage
|
@kprzerwa thank you for your contribution, could you please rebase? |
|
Could you please also add a release commit for version |
* fixes for best fit case (f.e. dimensions !400,200) - changed variable in the formula * expected behaviour for best fit case changed - now it resizes the image and keeps the ratio of an image and fills the background to requested size with black pixels - this helps to keep responsive images in the UI * adds the function to fill the pixels with black background if the best fit is smaller than requested thumbnail box size - preserves the thumbnail ratio * add the function to fill the background with black pixels for GIF if the best fit is smaller than requested window size * provides testing cases for portrait, landscape and fixed best fit case
|
@drjova thank you for the review, is it all ready to merge? |
lnielsen
approved these changes
May 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes for best fit case (f.e. dimensions !400,200) -
changed variable in the formula
expected behaviour for best fit case changed
an image and fills the background to requested size
with black pixels - this helps to keep responsive
images in the UI
adds the function to fill the pixels with
black background if the best fit is smaller
than requested thumbnail box size - preserves
the thumbnail ratio
add the function to fill the background with
black pixels for GIF if the best fit is
smaller than requested window size
provides testing cases for portrait, landscape
and fixed best fit case
related to requested fix: (closes
!parameter is not correctly calculated #47).