Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resources: rename to ResourceView #18

Open
ppanero opened this issue Jun 12, 2020 · 0 comments
Open

resources: rename to ResourceView #18

ppanero opened this issue Jun 12, 2020 · 0 comments
Labels
good first issue Good for newcomers

Comments

@ppanero
Copy link
Member

ppanero commented Jun 12, 2020

After talking IRL with @lnielsen, in context with what was discussed with @fenekku, we thought of renaming the Resource to ResourceView. This idea rose from the question "Should the resource return the http response code to the view?"


@lnielsen words:

Regarding e.g. Flask-RESTful and Flask-Resources: main issue is that none of the existing solutions is strong on content negotiation. E.g .flask restful adds 1) request parsing and 2) resourceful routing
Re 1), then webargs module does a lot better job
Re 2) resourceful routing, it basically doesn't add anything on top of a standard MethodView
and re. content negotiation it's too simplistic for our needs
The main thing that Flask-Resources adds is:

  1. Gathering multiple view endpoints for a REST resource into a single view class
  2. Decouples view from seralization/deserialization and allows this to be injected to the view
    We used Flask-RESTful in Flask-IIIF and initially considered it for Invenio-Records-REST but in the end went with MethodView
@ppanero ppanero added this to Triage in InvenioRDM June Board via automation Jun 12, 2020
@ppanero ppanero moved this from Triage to Backend To do in InvenioRDM June Board Jun 12, 2020
@lnielsen lnielsen added this to Todo in Architects via automation Jun 12, 2020
@lnielsen lnielsen removed this from Todo in Architects Jun 12, 2020
@ppanero ppanero mentioned this issue Jun 12, 2020
@ppanero ppanero moved this from Backend To do to In progress in InvenioRDM June Board Jun 18, 2020
@ppanero ppanero moved this from In progress to Backend To do in InvenioRDM June Board Jun 19, 2020
@ppanero ppanero removed this from Backend To do in InvenioRDM June Board Jun 26, 2020
@ppanero ppanero added this to Backend To do in InvenioRDM July Board Jun 26, 2020
@fenekku fenekku moved this from Backend To do to Todo in InvenioRDM July Board Jul 6, 2020
@fenekku fenekku changed the title resources: naming and responsability resources: rename to ResourceView Jul 27, 2020
@fenekku fenekku removed this from Todo in InvenioRDM July Board Jul 27, 2020
@fenekku fenekku added this to Triage in InvenioRDM August Board via automation Jul 27, 2020
@fenekku fenekku removed this from Triage in InvenioRDM August Board Aug 13, 2020
@fenekku fenekku added the good first issue Good for newcomers label Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants