Serializer #19
Merged
Serializer #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppanero
force-pushed
the
serializer
branch
3 times, most recently
from
ff54e76
to
b4dd095
Compare
Closed
fenekku
reviewed
Jun 16, 2020
There was a problem hiding this comment.
Let's talk tomorrow about how we want to procede with these PRs that are incremental/experimental. There are a lot of things that we know we will revisit, so it's hard to tell what we are settling...
It's mergeable if we agree to revisit a lot of aspects... 🤷
|
Rebasing and merging to get everything together. Once we do, it will be easier to know what to change/what is missing. |
added 19 commits
June 16, 2020 14:29
fenekku
force-pushed
the
serializer
branch
2 times, most recently
from
2520d40
to
aa2e05b
Compare
fenekku
approved these changes
Jun 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires #16
Closes #15 - Many record/invenio specific things have been moved to
invenio-resources. See more at inveniosoftware/invenio-records-resources#8.Closes #4 - The resource class does not
abortanymore. It returns the error code. How to treat it properlly needs to be addressed in #9 (see more below).Errors and serialization
Note that the default resource returns a 405 code with no content and then the views call
make_responseby default. The default views are made to work with the resource test case (A.K.A. How would a user create an API with this). However, changes in this area are needed to:1- Support the behaviour of the default resource, i.e. return a 405 forbidden error.
2- Do the distinction from error and successful response somewhere. Could we benefit from some other abstraction present in Flask/Other library?
This questions will and the whole error serialization will be treated separatelly in #3
Resources file hierarchy
The
resource.pycurrently contains theResource, theCollectionResource, theSingletonResourceand theResourceConfigclasses. Should they be separated into different files? If yes:resourcesfolder?viewsfolder?The answer will depend from and be treated in #18
Naming 🎊
The
SerializerMixinuses the wordobject, which is reserved. Any suggestions for a change?