Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

global: first beta including views, resources, context and content ne… #1

Merged
merged 6 commits into from
Jun 12, 2020
Merged

global: first beta including views, resources, context and content ne… #1

merged 6 commits into from
Jun 12, 2020

Conversation

ppanero
Copy link
Member

@ppanero ppanero commented Apr 28, 2020

No description provided.

@ppanero ppanero marked this pull request as ready for review April 28, 2020 09:12
@ppanero ppanero mentioned this pull request Apr 28, 2020
Merged
@fenekku fenekku mentioned this pull request Apr 28, 2020
Closed
37 tasks
fenekku
fenekku reviewed Apr 30, 2020
View reviewed changes
Copy link
Contributor

@fenekku fenekku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a pass just looking at those files. I will look at invenio-resources next to see this in action and things might become clearer.

run-tests.sh Show resolved Hide resolved
flask_resources/views/base.py Outdated Show resolved Hide resolved
flask_resources/context.py Show resolved Hide resolved
flask_resources/content_negotiation.py Show resolved Hide resolved
flask_resources/views/singleton.py Show resolved Hide resolved
flask_resources/errors.py Show resolved Hide resolved
flask_resources/resources.py Show resolved Hide resolved
@ppanero ppanero mentioned this pull request Jun 9, 2020
Closed
3 tasks
@fenekku fenekku self-requested a review June 10, 2020 23:47
fenekku
fenekku approved these changes Jun 10, 2020
View reviewed changes
Copy link
Contributor

@fenekku fenekku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good to go for now (I will revisit content-negotiation tomorrow)

@ppanero ppanero mentioned this pull request Jun 11, 2020
Merged
@ppanero ppanero merged commit da11686 into inveniosoftware:master Jun 12, 2020
@ppanero ppanero mentioned this pull request Jun 12, 2020
Closed
@ppanero ppanero deleted the beta branch June 17, 2020 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fenekku fenekku fenekku approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ppanero @fenekku @slint