Added i18w support + danish translation. #27
Conversation
|
|
||
| #: ../flask_security/templates/security/email/change_notice.html:4 | ||
| msgid "click here to reset it" | ||
| msgstr "click her for at ændre den" |
|
|
||
| #: ../flask_security/templates/security/send_confirmation.html:3 | ||
| msgid "Resend confirmation instructions" | ||
| msgstr "Gensend bekræftigelses instruktioner" |
There was a problem hiding this comment.
Gensend bekræftelses instruktioner
?
|
|
||
| #: ../flask_security/templates/security/_menu.html:9 | ||
| msgid "Forgot password" | ||
| msgstr "Glemt Adgangskode" |
| #!/bin/sh | ||
| pybabel extract -F babel.ini -k _gettext -k _ngettext -k lazy_gettext -o security.pot --project Flask-Security ../flask_security | ||
| pybabel compile -f -D security -d ../flask_security/translations/ | ||
|
|
There was a problem hiding this comment.
Can you remove the extra empty line?
| 'EMAIL_SUBJECT_PASSWORD_NOTICE': 'Your password has been reset', | ||
| 'EMAIL_SUBJECT_PASSWORD_CHANGE_NOTICE': 'Your password has been changed', | ||
| 'EMAIL_SUBJECT_PASSWORD_RESET': 'Password reset instructions', | ||
| 'DEFAULT_HTTP_AUTH_REALM': _('Login Required'), |
There was a problem hiding this comment.
IMHO in this file all strings should be only marked for translation and the gettext should be call in place where these strings are used so developers can provide text only configuration for their application.
There was a problem hiding this comment.
You mean if one specified feks EMAIL_SUBJECT_PASSWORD_NOTICE, as a normal text string in a config file, it should still be translated by gettext?
Or do you mean that using a normal string for EMAIL_SUBJECT_PASSWORD_NOTICE wouldn't result in errors? It shouldn't as far as I know as lazy_gettexts are only evaluated when used, so they behave as if they were ordinary strings.
There was a problem hiding this comment.
lazy_gettextsare only evaluated when used ...
This is a problem for configuration strings provided manually as str. They would not be translated when used.
There was a problem hiding this comment.
That is true. I guess this is ultimately a use-case philosophical discussion. People following the Flask Mega-Tutorial (myself included) wrap all configuration strings to be translated in lazy_gettext. This would work as well, and the translated files would end up in that person .mo files.
I can spend some time on an alternative solution if you're sure. Perhaps adding a callback somewhere. But I think its more complexity for no clear benefit.
There was a problem hiding this comment.
Maybe, I should have elaborate a bit more at the beginning. There are two steps for making the extension configurable and translation friendly.
- Make sure that all strings are properly extracted by Babel (usually done by
_or*gettextfunction). - Render translated string in UI.
For the first step we need to make sure that default configuration options are marked. This can be simply done by an identity function (def _(x): return x). In order to make second step correctly we need to make sure that the gettext (or it's lazy equivalent) function is call on each string that a user can see.
What if developer provides different configuration for Flask-Security messages?
First, (s)he needs to make sure that these strings are extracted from the sources and included in flask_security.mo that it's loaded by Flask-BabelEx.
I hope I have explained the problems well.
There was a problem hiding this comment.
Thanks it does, the login_manager from Flask-Login has a gettext callback that can be used, and I just have to find something similar and appropriate for the forms, and make sure its all done properly everywhere.
My test bed is up and running, so I can figure things out. A bit busy this week, but I'll have something by the weekend.
Thanks for helping out a guy with his first open source pull request. Kinda exciting. :)
There was a problem hiding this comment.
@LeonhardPrintz you are welcome 👍 I hope we can find an elegant solution. If you have any questions you can ping me here or on Gitter.
| class CustomDomain(Domain): | ||
| def __init__(self): | ||
| super(CustomDomain, self).__init__( | ||
| translations.__path__[0], domain='security') |
There was a problem hiding this comment.
Why do we choose domain name 'security' instead of 'flask_security'?
There was a problem hiding this comment.
This might be a bug, I'll make a small demo and see if anything is broken.
There was a problem hiding this comment.
It was, fixed in next commit.
I'm resubmitting this after squashing some fixup commits.