global: parsing fixes and HTTPS usage #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jirikuncar
requested changes
Sep 19, 2016
| @@ -47,11 +47,15 @@ | |||
| ('73513537', ['ean8'], '', ''), | |||
| ('15626865', ['issn', 'pmid'], '1562-6865', ''), | |||
| ('10013/epic.10033', ['handle'], '', | |||
| 'http://hdl.handle.net/10013/epic.10033'), | |||
There was a problem hiding this comment.
please add https and do not remove the existing test cases
| @@ -23,14 +23,14 @@ | |||
| from .version import __version__ | |||
|
|
|||
| doi_regexp = re.compile( | |||
| "(doi:|http://dx.doi.org/|https://dx.doi.org/|http://doi.org/|" | |||
| "https://doi.org/)?(10\.\d+(.\d+)*/.*)$", | |||
| "(doi:\s*|(?:https?://)?(?:dx\.)?doi\.org/)?(10\.\d+(.\d+)*/.*)$", | |||
There was a problem hiding this comment.
please add testcases for \s*
|
@slint please use |
slint
force-pushed
the
handle_fixes
branch
2 times, most recently
from
06ecbd7
to
5385393
Compare
jirikuncar
force-pushed
the
handle_fixes
branch
2 times, most recently
from
dd3fa54
to
fed14f3
Compare
jirikuncar
approved these changes
Sep 20, 2016
jirikuncar
force-pushed
the
handle_fixes
branch
from
fed14f3
to
5ea322a
Compare
* BETTER Detects and parses Handles and DOIs without the "http(s)://", and ignores whitespace after scheme tags (eg. "doi: 10.123/456"). * NEW Adds an optional parameter in `idutils.to_url` to use HTTPS scheme for PID providers that support it. Reviewed-by: Jiri Kuncar <jiri.kuncar@cern.ch> Signed-off-by: Alexander Ioannidis <a.ioannidis@cern.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.