Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the HAL (hal.archives-ouvertes.fr) id style #45

Merged
merged 2 commits into from
Mar 1, 2019

Conversation

marmol
Copy link

@marmol marmol commented Dec 7, 2018

As discussed with Lars in october, here is a patch for idutils be able to managed Hal (hal.archives-ouvertes.fr) identifier.
Hope it's correcte (tests passed)

@lnielsen lnielsen added this to Backlog in Invenio Sprint Dec 3 - Dec 14 2018 via automation Dec 7, 2018
@lnielsen
Copy link
Member

lnielsen commented Dec 7, 2018

Thanks a lot. We're taking a look at it

@lnielsen lnielsen moved this from Backlog to Todo - Webpack, Docker, Pipenv in Invenio Sprint Dec 3 - Dec 14 2018 Dec 7, 2018
@lnielsen lnielsen moved this from Todo - Webpack, Docker, Pipenv to Pending review in Invenio Sprint Dec 3 - Dec 14 2018 Dec 7, 2018
@@ -181,6 +181,10 @@
"""Matches new style arXiv ID, with an old-style class specification;
technically malformed, however appears in real data."""

hal_regexp = re.compile("(hal:)?([a-z]{3}[a-z]*-|(sic|mem|ijn)_)\d{8}$")
""" Matche HAL identifiers
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it possible that hal: will appear as uppercase? f.e. like in ads_regexp below?
minor: typo in docstring

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I correct on my side: accept hal:|HAL:
Fix typo (I hope... my english is not so good :-(

@lnielsen lnielsen moved this from Pending review to In progress in Invenio Sprint Dec 3 - Dec 14 2018 Dec 10, 2018
idutils/__init__.py Outdated Show resolved Hide resolved
@lnielsen
Copy link
Member

We're ready to release the changes now. Sorry for the long waiting time. Just one last thing. Who is the copyright holder of the contribution - normally this would be your employer (it has to be a legal entity - i.e. the legal name of your employer organisation). If you did this privately, it would be you as a person.

@marmol
Copy link
Author

marmol commented Feb 27, 2019

no problem for the waiting time... i am late too to answer to your copyright question;
The legal name of my organization is: Inria

@lnielsen lnielsen self-assigned this Mar 1, 2019
@lnielsen lnielsen merged commit e58f82f into inveniosoftware:master Mar 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants