-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the HAL (hal.archives-ouvertes.fr) id style #45
Conversation
Thanks a lot. We're taking a look at it |
idutils/__init__.py
Outdated
@@ -181,6 +181,10 @@ | |||
"""Matches new style arXiv ID, with an old-style class specification; | |||
technically malformed, however appears in real data.""" | |||
|
|||
hal_regexp = re.compile("(hal:)?([a-z]{3}[a-z]*-|(sic|mem|ijn)_)\d{8}$") | |||
""" Matche HAL identifiers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it possible that hal: will appear as uppercase? f.e. like in ads_regexp below?
minor: typo in docstring
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok I correct on my side: accept hal:|HAL:
Fix typo (I hope... my english is not so good :-(
We're ready to release the changes now. Sorry for the long waiting time. Just one last thing. Who is the copyright holder of the contribution - normally this would be your employer (it has to be a legal entity - i.e. the legal name of your employer organisation). If you did this privately, it would be you as a person. |
no problem for the waiting time... i am late too to answer to your copyright question; |
As discussed with Lars in october, here is a patch for idutils be able to managed Hal (hal.archives-ouvertes.fr) identifier.
Hope it's correcte (tests passed)