Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

global: add special role any_users and authenticated_users #128

Closed
wants to merge 2 commits into from

Conversation

remileduc
Copy link
Member

related to #56 and #124

(Default: ``None``)
:param entry_point_special_roles: The entrypoint for sepcial roles
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/sepcial/special/

Copy link
Member

@nharraud nharraud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the little typo mentioned above it looks good 👍

@lnielsen
Copy link
Member

lnielsen commented Aug 1, 2017

Looks good to me as well - let's discuss tomorrow the details, but I think System role might be better than Special role (and define system roles as roles that are managed by the system and automatically assigned to users)? WDYT?

@remileduc remileduc force-pushed the special_role branch 3 times, most recently from dde2f97 to d0bff12 Compare August 2, 2017 09:06
@remileduc
Copy link
Member Author

updated so we use system role instead

- use the travis user instead of root to make the tests pass
  (maybe something has changed since travis is using Trusty as
  default distrib)
- use precise distrib
@lnielsen
Copy link
Member

lnielsen commented Aug 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants