views: assign permission check fix #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* FIX Fixes application context misuse. (closes inveniosoftware#14) * BETTER Improves role assignment permission factory call by providing user and role paramters separately. (closes inveniosoftware#15) Signed-off-by: Nicolas Harraudeau <nicolas.harraudeau@cern.ch>
lnielsen
approved these changes
Jan 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIX Fixes application context misuse. (closes views: permission check functions misuse application context #14)
BETTER Improves role assignment permission factory call by
providing user and role paramters separately. (closes views: assign permission factory should pass user and role separately #15)
Signed-off-by: Nicolas Harraudeau nicolas.harraudeau@cern.ch