Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

views: initial auth implementation #36

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

slint
Copy link
Member

@slint slint commented Nov 27, 2019

No description provided.


def _abort(message, field=None, status=None):
if field:
raise RESTValidationError(FieldError(field, message))
Copy link
Member

@zzacharo zzacharo Dec 3, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RESTValidationError expects a list of errors line, thus this should be wrapped in a [FieldError(field, message))]

def _abort(message, field=None, status=None):
if field:
raise RESTValidationError(FieldError(field, message))
raise RESTValidationError(description=message)
Copy link
Member

@zzacharo zzacharo Dec 3, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will not work too as the RESTValidationError expects a specific forma of errors. I solved it here for invenio-files-rest but if you think it's worth it we can adapt this check in here

@slint slint added this to Backlog in Sprint Week 10-11 (2020) - V3.3 Release via automation Feb 28, 2020
@slint slint moved this from Backlog to In progress in Sprint Week 10-11 (2020) - V3.3 Release Feb 28, 2020
@slint slint removed this from In progress in Sprint Week 10-11 (2020) - V3.3 Release Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants