global: circulation specific user search #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mvesper
commented
Sep 6, 2016
mvesper
commented
- Adds a first REST API implementation for invenio_accounts.models.User that handles current invenio-circulation needs.
| def get(self): | ||
| """Get accounts/users/?q=.""" | ||
| query = request.args.get('q') | ||
| return list(User.query.filter( |
There was a problem hiding this comment.
User.query.filter(...).all() or .paginate(...)
mvesper
force-pushed
the
circulation_initial
branch
2 times, most recently
from
86bf405
to
ab1850f
Compare
|
@mvesper can you fix Python 3.3 or just remove Python 3.3, 3.4 from setup.py and .travis.yml. Thanks |
mvesper
force-pushed
the
circulation_initial
branch
from
ab1850f
to
3e6f7f4
Compare
mvesper
force-pushed
the
circulation_initial
branch
from
3e6f7f4
to
b8716b4
Compare
| def get(self): | ||
| """Get accounts/users/?q=.""" | ||
| query = request.args.get('q') | ||
| return User.query.filter( |
There was a problem hiding this comment.
we should filter only if query:
* Adds a first REST API implementation for *invenio_accounts.models.User* that handles current *invenio-circulation* needs.
mvesper
force-pushed
the
circulation_initial
branch
from
b8716b4
to
a7f9d09
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.