dependencies: fix missing email_validator [more] #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a 'quick' fix for the 2.3.1 breaking change in wtforms that requires the email-validator library. WTForms is brought in from flask-security and flask-security is a dependency of invenio-accounts. The real fix would be switching to 'flask-security-too` since flask-security is not maintained anymore. However, a cursory attempt has generated more errors. So until we can address those errors, this fix can do. - also fixes pytest dependency issues
37 tasks
lnielsen
approved these changes
Apr 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a 'quick' fix for the 2.3.1 breaking change in wtforms
that requires the email-validator library. WTForms is brought in
from flask-security and flask-security is a dependency of
invenio-accounts.
The real fix would be switching to flask-security-too since
flask-security is not maintained anymore. However, a cursory attempt
has generated more errors. So until we can address those errors,
this fix can do. (things like
security.forgot_passwordnot resolving to a route...)