bug: fix type for BoolFormatter value

[carlinmack]

❤️ Thank you for your contribution!

Description

Please describe briefly your pull request.

1st commit

value is used as a boolean, and therefore all the uses of this in the codebase pass a boolean test as value. I think value isn't a great name for this, but at least we should fix the expected type

class BoolFormatter extends React.Component {
  render() {
    const { value, icon, color, tooltip } = this.props;
    if (!value) {
      return null;
    }
    return <Icon title={tooltip} name={icon} color={color} />;
  }
}

2nd commit

There is a warning from eslint that we should provide a default value for the tooltip and looking at the repository, this icon is used to mean a variety of things such as activated, success, verified, confirmed, etc. As such I don't think we can define a sensible default value for tooltip

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

• I'm aware of the code of conduct.
• I've created logical separate commits and followed the commit message format.
• I've added relevant test cases.
• I've added relevant documentation.
• I've marked translation strings.
• I've identified the copyright holder(s) and updated copyright headers for touched files (>15 lines contributions).
• I've NOT included third-party code (copy/pasted source code or new dependencies).
  • If you have added third-party code (copy/pasted or new dependencies), please reach out to an architect.

Frontend

• I've followed the CSS/JS and React guidelines.
• I've followed the web accessibility guidelines.
• I've followed the user interface guidelines.

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

1. You license your contribution under the same terms as the current repository’s license.
2. You agree that you have the right to license your contribution under the current repository’s license.

[alejandromumo]

We need to check how this BoolFormatter is being used in all the codebase, sometimes we pass a boolean and othertimes we pass an object.