form: added support for json fields

[0einstein0]

❤️ Thank you for your contribution!

Description

Closes inveniosoftware/invenio-jobs#23

• Right now using TextAreaField for the json object so need to transform it accordingly before rendering in the form and submitting
• Will introduce a separate component for json specifically in future

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

• I'm aware of the code of conduct.
• I've created logical separate commits and followed the commit message format.
• I've added relevant test cases.
• I've added relevant documentation.
• I've marked translation strings.
• I've identified the copyright holder(s) and updated copyright headers for touched files (>15 lines contributions).
• I've NOT included third-party code (copy/pasted source code or new dependencies).
  • If you have added third-party code (copy/pasted or new dependencies), please reach out to an architect.

Frontend

• I've followed the CSS/JS and React guidelines.
• I've followed the web accessibility guidelines.
• I've followed the user interface guidelines.

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

1. You license your contribution under the same terms as the current repository’s license.
2. You agree that you have the right to license your contribution under the current repository’s license.

[slint]

LGTM, some minor comments (and one to be shelved).

[slint]

minor: wouldn't it be better to explicitly have a clause for the "json" type? Or are there cases where this type is "inferred" somewhere and we have to exclude it explicitly here?

[0einstein0]

I set it as json in the metadata.type in the schema otherwise it is interpreted as an object, hence why I had to add this check here. Could have made a separate for just json but it is just rendering a TextField for now like strings so I put it there for now as we are planning on adding support for json/code later I assume

invenio-administration/invenio_administration/assets/semantic-ui/js/invenio_administration/src/formik/GenerateForm.js

Line 175 in 636066f

fieldSchema.metadata?.type === "json"

    if (
      (fieldSchema.type === "string" && rows) ||
      fieldSchema.metadata?.type === "json"
    ) {
      return (
        <TextArea
          key={fieldProps.fieldPath}
          fieldPath={fieldProps.fieldPath}
          rows={rows}
          {...fieldProps}
        />
      );
    }

[slint]

minor/shelve: I feel that the whole conversion/validation logic is spread throughout the module, instead of specific components/classes being responsible for it. Not sure if it should be addressed in this PR, but definitely something to look into in the future.

On a separate note, it's likely that in the future we'll look into integrating a dedicated code-editor style of form field for JSON (or YAML), where I would expect the form control to be responsible for all this logic.