Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Profile page of patron (not admin!) broken #742

Closed
kpsherva opened this issue Feb 17, 2020 · 1 comment
Closed

Profile page of patron (not admin!) broken #742

kpsherva opened this issue Feb 17, 2020 · 1 comment
Assignees
@topless
Labels
Aim-frontsite Work on end-user interface bug Something isn't working

Comments

@kpsherva
Copy link
Contributor

No description provided.

@kpsherva kpsherva added bug Something isn't working Aim-frontsite Work on end-user interface labels Feb 17, 2020
This was referenced Feb 18, 2020
Closed
Closed
@topless
Copy link
Member

topless commented Feb 19, 2020

It is fixed in pr #746 which will address the issue #743

@topless topless closed this as completed Feb 19, 2020
topless added a commit to topless/invenio-app-ils that referenced this issue Feb 20, 2020
@topless
document requests: makeover
c0024f7 
- patron can cancel its own literature request
- restored circulation in resolved document
- rename onChangeDocument to onRemoveDocument
- restructured document request endpoints
- Document Request Reject need_record_permission
- confirmation modal when patron cancels literature request
- fix message for no literature requests
- cast patron_pid as a string when we fetch it
- refactored common helpers
- document request custom endpoints permission test
- rename the PendingRequestResource to be more explicit
- fix OrderSubmitForm serializer from inveniosoftware#738
- closes inveniosoftware#742 add the circulation field in the loan resolver in loan.py:document_resolver(loan_pid)
- closes inveniosoftware#743
topless added a commit to topless/invenio-app-ils that referenced this issue Feb 21, 2020
@topless
document requests: makeover
23acb2e 
- patron can cancel its own literature request
- restored circulation in resolved document
- rename onChangeDocument to onRemoveDocument
- restructured document request endpoints
- Document Request Reject need_record_permission
- confirmation modal when patron cancels literature request
- fix message for no literature requests
- cast patron_pid as a string when we fetch it
- refactored common helpers
- document request custom endpoints permission test
- rename the PendingRequestResource to be more explicit
- fix OrderSubmitForm serializer from inveniosoftware#738
- closes inveniosoftware#742 add the circulation field in the loan resolver in loan.py:document_resolver(loan_pid)
- closes inveniosoftware#743
topless added a commit to topless/invenio-app-ils that referenced this issue Feb 25, 2020
@topless
document requests: makeover
7e8c0af 
- patron can cancel its own literature request
- restored circulation in resolved document
- rename onChangeDocument to onRemoveDocument
- restructured document request endpoints
- Document Request Reject need_record_permission
- confirmation modal when patron cancels literature request
- fix message for no literature requests
- cast patron_pid as a string when we fetch it
- refactored common helpers
- document request custom endpoints permission test
- rename the PendingRequestResource to be more explicit
- fix OrderSubmitForm serializer from inveniosoftware#738
- closes inveniosoftware#742 add the circulation field in the loan resolver in loan.py:document_resolver(loan_pid)
- closes inveniosoftware#743
kpsherva pushed a commit that referenced this issue Feb 25, 2020
@topless
frontsite: patron can cancel its own literature request (#746)
defc369 
* document requests: makeover

- patron can cancel its own literature request
- restored circulation in resolved document
- rename onChangeDocument to onRemoveDocument
- restructured document request endpoints
- Document Request Reject need_record_permission
- confirmation modal when patron cancels literature request
- fix message for no literature requests
- cast patron_pid as a string when we fetch it
- refactored common helpers
- document request custom endpoints permission test
- rename the PendingRequestResource to be more explicit
- fix OrderSubmitForm serializer from #738
- closes #742 add the circulation field in the loan resolver in loan.py:document_resolver(loan_pid)
- closes #743
- addressed review comments
- implemented isAuthenticated for session manager, to replace the property authenticated which was never defined
- fixed an issue with item link for loan when there is no item available
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@topless topless

Labels
Aim-frontsite Work on end-user interface bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@topless @kpsherva