deposit form: add sharing of drafts

* closes #2667

invenio_app_rdm/records_ui/templates/semantic-ui/invenio_app_rdm/records/deposit.html

@@ -41,12 +41,12 @@
            value='{{ files | tojson }}'>
   {%- endif %}
 
-  {%- if config %}
-    <input type="hidden" name="deposits-record-restriction-grace-period"
-           value='{{ config.RDM_RECORDS_RESTRICTION_GRACE_PERIOD.days | tojson }}'>
-    <input type="hidden" name="deposits-allow-record-restriction"
-           value='{{ config.RDM_RECORDS_ALLOW_RESTRICTION_AFTER_GRACE_PERIOD | tojson }}'>
-  {%- endif %}
+  <input type="hidden" name="deposits-record-restriction-grace-period"
+          value='{{ config.RDM_RECORDS_RESTRICTION_GRACE_PERIOD.days | tojson }}'>
+  <input type="hidden" name="deposits-allow-record-restriction"
+          value='{{ config.RDM_RECORDS_ALLOW_RESTRICTION_AFTER_GRACE_PERIOD | tojson }}'>
+  <input type="hidden" name="config-groups-enabled"
+          value='{{ config.USERS_RESOURCES_GROUPS_ENABLED | tojson }}'>
 
   {%- if forms_config %}
     <input type="hidden" name="deposits-config"

invenio_app_rdm/records_ui/templates/semantic-ui/invenio_app_rdm/records/details/side_bar/manage_menu.html

@@ -18,7 +18,6 @@
          data-is-preview-submission-request="{{ is_preview_submission_request | tojson }}"
          data-current-user-id="{{ current_user.id }}"
          data-record-owner-username='{{ record_owner_username }}'
-         data-access-links-search-config='{{ search_app_access_links_config(app_id="InvenioAppRdm.AccessLinks", endpoint=record.links.access_links) | tojson }}'
          data-groups-enabled='{{ config.USERS_RESOURCES_GROUPS_ENABLED | tojson }}'
     >
       <div class="ui placeholder">

invenio_app_rdm/records_ui/views/deposits.py

@@ -400,6 +400,7 @@ def deposit_create(community=None):
         files_locked=False,
         permissions=get_record_permissions(
             [
+                "manage",
                 "manage_files",
                 "delete_draft",
                 "manage_record_access",
@@ -465,6 +466,7 @@ def deposit_edit(pid_value, draft=None, draft_files=None, files_locked=True):
         files_locked=files_locked,
         permissions=draft.has_permissions_to(
             [
+                "manage",
                 "new_version",
                 "delete_draft",
                 "manage_files",

invenio_app_rdm/records_ui/views/records.py

@@ -419,15 +419,16 @@ def record_permission_denied_error(error):
 
     record = getattr(error, "record", None)
 
-    is_restricted = record.get("access", {}).get("record", None) == "restricted"
-    has_doi = "doi" in record.get("pids", {})
-    if record and is_restricted and has_doi:
-        return (
-            render_template(
-                "invenio_app_rdm/records/restricted_tombstone.html",
-                record=record,
-            ),
-            403,
-        )
+    if record:
+        is_restricted = record.get("access", {}).get("record", None) == "restricted"
+        has_doi = "doi" in record.get("pids", {})
+        if is_restricted and has_doi:
+            return (
+                render_template(
+                    "invenio_app_rdm/records/restricted_tombstone.html",
+                    record=record,
+                ),
+                403,
+            )
 
     return render_template(current_app.config["THEME_403_TEMPLATE"]), 403

invenio_app_rdm/theme/assets/semantic-ui/js/invenio_app_rdm/deposit/RDMDepositForm.js

@@ -43,6 +43,7 @@ import { FundingField } from "@js/invenio_vocabularies";
 import { Card, Container, Grid, Ref, Sticky } from "semantic-ui-react";
 import PropTypes from "prop-types";
 import Overridable from "react-overridable";
+import { ShareDraftButton } from "./ShareDraftButton";
 
 export class RDMDepositForm extends Component {
   constructor(props) {
@@ -105,6 +106,7 @@ export class RDMDepositForm extends Component {
       filesLocked,
       recordRestrictionGracePeriod,
       allowRecordRestriction,
+      groupsEnabled,
     } = this.props;
     const customFieldsUI = this.config.custom_fields.ui;
     return (
@@ -622,6 +624,16 @@ export class RDMDepositForm extends Component {
                           <Grid.Column width={16} className="pt-10">
                             <PublishButton fluid />
                           </Grid.Column>
+
+                          <Grid.Column width={16} className="pt-0">
+                            {(record.is_draft === null || permissions.can_manage) && (
+                              <ShareDraftButton
+                                record={record}
+                                permissions={permissions}
+                                groupsEnabled={groupsEnabled}
+                              />
+                            )}
+                          </Grid.Column>
                         </Grid>
                       </Card.Content>
                     </Card>
@@ -663,6 +675,7 @@ export class RDMDepositForm extends Component {
 }
 
 RDMDepositForm.propTypes = {
+  groupsEnabled: PropTypes.bool.isRequired,
   config: PropTypes.object.isRequired,
   recordRestrictionGracePeriod: PropTypes.object.isRequired,
   allowRecordRestriction: PropTypes.bool.isRequired,

invenio_app_rdm/theme/assets/semantic-ui/js/invenio_app_rdm/deposit/ShareDraftButton.js

@@ -0,0 +1,65 @@
+// This file is part of InvenioRDM
+// Copyright (C) 2024 CERN.
+//
+// Invenio RDM Records is free software; you can redistribute it and/or modify it
+// under the terms of the MIT License; see LICENSE file for more details.
+
+import React, { Component } from "react";
+import PropTypes from "prop-types";
+import { connect as connectFormik } from "formik";
+import { connect } from "react-redux";
+import _get from "lodash/get";
+import { ShareButton } from "../landing_page/ShareOptions/ShareButton";
+
+class ShareDraftButtonComponent extends Component {
+  isDisabled = (values, isSubmitting, numberOfFiles) => {
+    const { disabled } = this.props;
+    if (disabled) return true;
+
+    const filesEnabled = _get(values, "files.enabled", false);
+    const filesMissing = filesEnabled && !numberOfFiles;
+    const dataEmpty = Object.keys(values.expanded).length === 0;
+
+    return isSubmitting || filesMissing || dataEmpty;
+  };
+
+  render() {
+    const { numberOfFiles, record, permissions, groupsEnabled, formik } = this.props;
+    const { values, isSubmitting } = formik;
+
+    record.expanded = values.expanded;
+    record.links = values.links;
+    record.parent.access["settings"] = values.parent?.access?.settings;
+
+    return (
+      <ShareButton
+        disabled={this.isDisabled(values, isSubmitting, numberOfFiles)}
+        record={record}
+        permissions={permissions}
+        groupsEnabled={groupsEnabled}
+      />
+    );
+  }
+}
+
+ShareDraftButtonComponent.propTypes = {
+  disabled: PropTypes.bool,
+  record: PropTypes.object.isRequired,
+  permissions: PropTypes.object.isRequired,
+  groupsEnabled: PropTypes.bool.isRequired,
+  formik: PropTypes.object.isRequired,
+  numberOfFiles: PropTypes.number.isRequired,
+};
+
+ShareDraftButtonComponent.defaultProps = {
+  disabled: false,
+};
+
+const mapStateToProps = (state) => ({
+  numberOfFiles: Object.values(state.files.entries).length,
+});
+
+export const ShareDraftButton = connect(
+  mapStateToProps,
+  null
+)(connectFormik(ShareDraftButtonComponent));

invenio_app_rdm/theme/assets/semantic-ui/js/invenio_app_rdm/deposit/index.js

@@ -26,6 +26,7 @@ ReactDOM.render(
         "deposits-record-restriction-grace-period"
       )}
       allowRecordRestriction={getInputFromDOM("deposits-allow-record-restriction")}
+      groupsEnabled={getInputFromDOM("config-groups-enabled")}
     />
   </OverridableContext.Provider>,
   document.getElementById("deposit-form")

invenio_app_rdm/theme/assets/semantic-ui/js/invenio_app_rdm/landing_page/RecordManagement.js

@@ -32,7 +32,6 @@ export class RecordManagement extends Component {
       isDraft,
       isPreviewSubmissionRequest,
       currentUserId,
-      accessLinksSearchConfig,
       recordOwnerUsername,
       groupsEnabled,
     } = this.props;
@@ -87,7 +86,6 @@ export class RecordManagement extends Component {
                 <ShareButton
                   disabled={!permissions.can_update_draft}
                   record={record}
-                  accessLinksSearchConfig={accessLinksSearchConfig}
                   permissions={permissions}
                   groupsEnabled={groupsEnabled}
                 />
@@ -121,5 +119,4 @@ RecordManagement.propTypes = {
   isPreviewSubmissionRequest: PropTypes.bool.isRequired,
   currentUserId: PropTypes.string.isRequired,
   recordOwnerUsername: PropTypes.object.isRequired,
-  accessLinksSearchConfig: PropTypes.object.isRequired,
 };

invenio_app_rdm/theme/assets/semantic-ui/js/invenio_app_rdm/landing_page/ShareOptions/AccessLinks/LinksSearchResultContainer.js

@@ -19,16 +19,16 @@ export const dropdownOptions = [
   {
     key: "view",
     name: "view",
-    text: i18next.t("Can view all versions"),
-    title: i18next.t("Can view all versions"),
+    text: i18next.t("Can view"),
+    title: i18next.t("Can view"),
     value: "view",
     description: i18next.t("Can view restricted files of all versions of this record."),
   },
   {
     key: "preview",
     name: "preview",
-    text: i18next.t("Can preview all drafts"),
-    title: i18next.t("Can preview all drafts"),
+    text: i18next.t("Can preview drafts"),
+    title: i18next.t("Can preview drafts"),
     value: "preview",
     description: i18next.t(
       "Can view drafts and restricted files of all versions of this record."
@@ -37,8 +37,8 @@ export const dropdownOptions = [
   {
     key: "edit",
     name: "edit",
-    text: i18next.t("Can edit all versions"),
-    title: i18next.t("Can edit all versions"),
+    text: i18next.t("Can edit"),
+    title: i18next.t("Can edit"),
     value: "edit",
     description: i18next.t(
       "Can edit drafts and view restricted files of all versions of this record."

invenio_app_rdm/theme/assets/semantic-ui/js/invenio_app_rdm/landing_page/ShareOptions/AccessUsersGroups/AccessUsersGroups.js

@@ -110,7 +110,7 @@ export class AccessUsersGroups extends Component {
                                   }`}
                                 >
                                   <b className="mr-10">
-                                    {recOwner.profile.full_name || recOwner.username}
+                                    {recOwner.profile?.full_name || recOwner.username}
                                   </b>
                                   {recOwner.is_current_user && (
                                     <Label size="tiny" className="primary">

invenio_app_rdm/theme/assets/semantic-ui/js/invenio_app_rdm/landing_page/ShareOptions/AccessUsersGroups/UserGroupAccessSearchResultItem.js

@@ -21,8 +21,8 @@ export const accessDropdownOptions = [
   {
     key: "manage",
     name: "manage",
-    text: i18next.t("Can manage all versions"),
-    title: i18next.t("Can manage all versions"),
+    text: i18next.t("Can manage"),
+    title: i18next.t("Can manage"),
     value: "manage",
     description: i18next.t(
       "Can manage access, edit drafts and view restricted files of all versions of this record."

invenio_app_rdm/theme/assets/semantic-ui/js/invenio_app_rdm/landing_page/ShareOptions/ShareButton.js

@@ -13,13 +13,7 @@ import { ShareModal } from "./ShareModal";
 import { i18next } from "@translations/invenio_app_rdm/i18next";
 import PropTypes from "prop-types";
 
-export const ShareButton = ({
-  disabled,
-  record,
-  accessLinksSearchConfig,
-  permissions,
-  groupsEnabled,
-}) => {
+export const ShareButton = ({ disabled, record, permissions, groupsEnabled }) => {
   const [modalOpen, setModalOpen] = useState(false);
   const handleOpen = () => setModalOpen(true);
   const handleClose = () => setModalOpen(false);
@@ -50,7 +44,6 @@ export const ShareButton = ({
         handleClose={handleClose}
         record={record}
         permissions={permissions}
-        accessLinksSearchConfig={accessLinksSearchConfig}
         groupsEnabled={groupsEnabled}
       />
     </>
@@ -60,7 +53,6 @@ export const ShareButton = ({
 ShareButton.propTypes = {
   disabled: PropTypes.bool,
   record: PropTypes.object.isRequired,
-  accessLinksSearchConfig: PropTypes.object.isRequired,
   permissions: PropTypes.object.isRequired,
   groupsEnabled: PropTypes.bool.isRequired,
 };

invenio_app_rdm/theme/assets/semantic-ui/js/invenio_app_rdm/landing_page/ShareOptions/ShareModal.js

@@ -84,7 +84,7 @@ export class ShareModal extends Component {
     this.setState({ record: updatedRecord });
   };
 
-  panes = (record, accessLinksSearchConfig, permissions) => {
+  panes = (record, permissions) => {
     const { handleClose, groupsEnabled } = this.props;
     const { linksResults, groupsResults, usersResults } = this.state;
 
@@ -175,7 +175,7 @@ export class ShareModal extends Component {
   };
 
   render() {
-    const { open, handleClose, accessLinksSearchConfig, permissions } = this.props;
+    const { open, handleClose, permissions } = this.props;
     const { record, activeTab } = this.state;
     return (
       <Modal
@@ -197,7 +197,7 @@ export class ShareModal extends Component {
 
         <Tab
           menu={{ secondary: true, pointing: true }}
-          panes={this.panes(record, accessLinksSearchConfig, permissions)}
+          panes={this.panes(record, permissions)}
           onTabChange={this.handleTabChange}
         />
         {(activeTab === 0 || activeTab === 1 || activeTab === 2) && (
@@ -220,6 +220,5 @@ ShareModal.propTypes = {
   open: PropTypes.bool.isRequired,
   groupsEnabled: PropTypes.bool.isRequired,
   handleClose: PropTypes.func.isRequired,
-  accessLinksSearchConfig: PropTypes.object.isRequired,
   permissions: PropTypes.object.isRequired,
 };

invenio_app_rdm/theme/assets/semantic-ui/js/invenio_app_rdm/landing_page/index.js

@@ -43,9 +43,6 @@ function renderRecordManagement(element) {
         )}
         currentUserId={recordManagementAppDiv.dataset.currentUserId}
         recordOwnerUsername={recordManagementAppDiv.dataset.recordOwnerUsername}
-        accessLinksSearchConfig={JSON.parse(
-          recordManagementAppDiv.dataset.accessLinksSearchConfig
-        )}
         groupsEnabled={JSON.parse(recordManagementAppDiv.dataset.groupsEnabled)}
       />
     </OverridableContext.Provider>,