Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

webpack: find a better way to inject "theme.config" from Semantic-UI LESS #120

Closed
slint opened this issue May 13, 2020 · 1 comment
Closed

webpack: find a better way to inject "theme.config" from Semantic-UI LESS #120

slint opened this issue May 13, 2020 · 1 comment
Assignees
@lnielsen @slint
Projects
InvenioRDM May Board

Comments

@slint
Copy link
Member

slint commented May 13, 2020

Currently, we hard-code the on from invenio-themes in the resolver as an alias: https://github.com/inveniosoftware/invenio-assets/pull/115/files#diff-7041ec923e4ebff4bd440b0171487e16R30

This should be injected somehow from Flask into the Webpack config, to also allow other bundles to override it and provide their own...
@slint slint mentioned this issue May 13, 2020
Merged
@lnielsen lnielsen moved this from Backlog to For next week in Sprint Week 19-20 - Semantic UI transition May 15, 2020
@lnielsen lnielsen added this to In progress in InvenioRDM May Board May 26, 2020
@slint
Copy link
Member Author

slint commented May 26, 2020 •
edited

This is now possible via the use of bundle aliases, which get injected into webpack.config.js. The way to go is that in your overlay, you define your own Webpack bundle, and define a ../../theme.config alias pointing to your overlay's theme.config file.

See #123, inveniosoftware/invenio-theme#169, and inveniosoftware/cookiecutter-invenio-instance#236

@slint slint closed this as completed May 26, 2020
InvenioRDM May Board automation moved this from In progress to Done May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lnielsen lnielsen

@slint slint

Labels
None yet
Projects
No open projects
InvenioRDM May Board
  
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lnielsen @slint