webpack: add aliases support #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slint
added this to Backlog
in Sprint Week 19-20 - Semantic UI transition
via automation
ntarocco
reviewed
May 19, 2020
| // Semantic-UI LESS config resolving alias | ||
| // TODO: This would be better injected via config from Flask... | ||
| "../../theme.config$": path.resolve(config.build.context, "less/invenio_theme/theme.config"), | ||
| ...aliases, |
There was a problem hiding this comment.
I would remove the @templates now, and move it to a Invenio RDM config
There was a problem hiding this comment.
|
Note: adding this method to inject Webpack aliases doesn't cancel out inveniosoftware/pywebpack#27, which can still be useful for generally adding aliases. |
This was referenced May 19, 2020
slint
moved this from Backlog
to Pending review
in Sprint Week 19-20 - Semantic UI transition
slint
moved this from Pending review
to For next week
in Sprint Week 19-20 - Semantic UI transition
|
Tests seem to be failing because Flask-WebpackExt docs are not properly built? |
|
@slint we. had that issue several times during the sprint. read the docs are built in py27 in many cases. If you change it to python 3 they built again properly. |
slint
changed the title
Sprint Week 19-20 - Semantic UI transition
automation
moved this from For next week
to Done
May 25, 2020
lnielsen
reviewed
May 25, 2020
| def dependencies(self): | ||
| """Proxy to the active theme's bundle dependencies.""" | ||
| return self._active_theme_bundle.dependencies | ||
| def __getattr__(self, attr): |
There was a problem hiding this comment.
This one is causing troubles with tests in Invenio-Theme:
__________________ ERROR collecting invenio_theme/webpack.py ___________________
450/opt/python/3.7.1/lib/python3.7/doctest.py:932: in find
451 self._find(tests, obj, name, module, source_lines, globs, {})
452../../../virtualenv/python3.7.1/lib/python3.7/site-packages/_pytest/doctest.py:476: in _find
453 self, tests, obj, name, module, source_lines, globs, seen
454/opt/python/3.7.1/lib/python3.7/doctest.py:991: in _find
455 if ((inspect.isroutine(inspect.unwrap(val))
456../../../virtualenv/python3.7.1/lib/python3.7/site-packages/_pytest/doctest.py:427: in _mock_aware_unwrap
457 return real_unwrap(obj, stop=_is_mocked)
458/opt/python/3.7.1/lib/python3.7/inspect.py:511: in unwrap
459 while _is_wrapper(func):
460/opt/python/3.7.1/lib/python3.7/inspect.py:505: in _is_wrapper
461 return hasattr(f, '__wrapped__') and not stop(f)
462../../../virtualenv/python3.7.1/lib/python3.7/site-packages/invenio_assets/webpack.py:65: in __getattr__
463 return getattr(self._active_theme_bundle, attr)
464../../../virtualenv/python3.7.1/lib/python3.7/site-packages/invenio_assets/webpack.py:56: in _active_theme_bundle
465 themes = current_app.config.get('APP_THEME', [])
466../../../virtualenv/python3.7.1/lib/python3.7/site-packages/werkzeug/local.py:347: in __getattr__
467 return getattr(self._get_current_object(), name)
468../../../virtualenv/python3.7.1/lib/python3.7/site-packages/werkzeug/local.py:306: in _get_current_object
469 return self.__local()
470../../../virtualenv/python3.7.1/lib/python3.7/site-packages/flask/globals.py:52: in _find_app
471 raise RuntimeError(_app_ctx_err_msg)
472E RuntimeError: Working outside of application context.
473E
474E This typically means that you attempted to use functionality that needed
475E to interface with the current application object in some way. To solve
476E this, set up an application context with app.app_context(). See the
477E documentation for more information.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.