global: expose get loan for item logic and refactoring #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ntarocco
commented
Oct 20, 2018
ntarocco
commented
- extracts the logic to retrieve the loan status for an item in api
- changes schema and record creation to have mandatory loan_pid field
- fixes bug when searching loans by pid
- fixes db commit and indexing after loan change
- moves PIDs constants in a common module
- moves blueprints registration to entrypoints
- improves tests and fixtures
ntarocco
force-pushed
the
circulation-status-for-item
branch
2 times, most recently
from
9b4019c
to
09adad6
Compare
* extracts the logic to retrieve the loan status for an item in api * changes schema and record creation to have mandatory loan_pid field * fixes bug when searching loans by pid * fixes db commit and indexing after loan change * moves PIDs constants in a common module * moves blueprints registration to entrypoints * improves tests and fixtures * closes inveniosoftware#59
ntarocco
force-pushed
the
circulation-status-for-item
branch
from
09adad6
to
0efa574
Compare
kpsherva
reviewed
Oct 22, 2018
| @@ -12,12 +12,11 @@ | |||
| "$schema": { | |||
| "type": "keyword" | |||
| }, | |||
| "loanid": { | |||
| "loan_pid": { | |||
There was a problem hiding this comment.
👍 thanks for that, I was lost in different naming for ids
| @@ -12,12 +12,11 @@ | |||
| "$schema": { | |||
| "type": "keyword" | |||
| }, | |||
| "loanid": { | |||
| "loan_pid": { | |||
There was a problem hiding this comment.
👍 thanks for that, I was lost in different naming for ids
| @@ -18,8 +18,7 @@ | |||
| "index": "not_analyzed" | |||
| }, | |||
| "transaction_date": { | |||
| "type": "date", | |||
| "format": "yyyy-MM-dd" | |||
There was a problem hiding this comment.
Do we have a global date format now?
There was a problem hiding this comment.
So, dates are in this format for now:
2018-02-01T09:30:00+02:00
ES will automatically pick the right date format, but it could be that we will change it if it not good enough.
kpsherva
approved these changes
Oct 22, 2018
|
Reviewed also with Zac |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.