fix: receivers parameters #85
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
jacquerie
reviewed
Dec 21, 2017
| @@ -106,7 +106,7 @@ def __init__(self, app=None): | |||
| from .percolator import _find_matching_collections_externally | |||
| self.matcher = _find_matching_collections_externally | |||
|
|
|||
| def __call__(self, record, **kwargs): | |||
| def __call__(self, sender, record, **kwargs): | |||
There was a problem hiding this comment.
As Travis says, you will also need to amend the tests correspondingly. But I want to know why is this change needed: can you point me to the signature of the signal?
There was a problem hiding this comment.
It's probably due to inveniosoftware/invenio-records@cd3a7d2 (backward incompatible change)
lnielsen
reviewed
Dec 21, 2017
| @@ -106,7 +106,7 @@ def __init__(self, app=None): | |||
| from .percolator import _find_matching_collections_externally | |||
| self.matcher = _find_matching_collections_externally | |||
|
|
|||
| def __call__(self, record, **kwargs): | |||
| def __call__(self, sender, record, **kwargs): | |||
There was a problem hiding this comment.
it should probably be ..., sender, record=None, ...
There was a problem hiding this comment.
And you might need to bump lowest invenio-records dependency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Johnny Mariéthoz Johnny.Mariethoz@rero.ch