Fix communities creation check #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slint
reviewed
Sep 23, 2020
| <h2> | ||
| {{ _('My communities') }} | ||
| <div class="pull-right"> | ||
| <a href="{{url_for('.new')}}" class="btn btn-primary"><i class="icon-plus-sign"></i> {{ _('New') }}</a> | ||
| <a href="{{url_for('.new')}}" class="btn btn-primary" {{ "disabled" if not can_user_create_community(current_user) }}><i class="icon-plus-sign"></i> {{ _('New') }}</a> |
There was a problem hiding this comment.
Suggested change
| <a href="{{url_for('.new')}}" class="btn btn-primary" {{ "disabled" if not can_user_create_community(current_user) }}><i class="icon-plus-sign"></i> {{ _('New') }}</a> | |
| <a href="{{url_for('.new')}}" class="btn btn-primary {{ "disabled" if not can_user_create_community(current_user) }}" {{ "disabled" if not can_user_create_community(current_user) }}><i class="icon-plus-sign"></i> {{ _('New') }}</a> |
This also makes the button unclickable
| @@ -10,10 +10,13 @@ | |||
| <div class="well"> | |||
| {% if current_user.is_authenticated %} | |||
| {% if mycommunities %} | |||
| {% if not can_user_create_community(current_user) %} | |||
There was a problem hiding this comment.
I would extract this as a variable at the beginning of the template:
{% set can_create_community = can_user_create_community(current_user) %}and then use appropriately below
invenio_communities/views/ui.py
Outdated
| @@ -177,6 +176,10 @@ def new(): | |||
| for at least one week. If you want to speed up the process, you \ | |||
There was a problem hiding this comment.
Instead of \, it's better to use string literal lines in parentheses, just to be sure about the whitespace
Glignos
force-pushed
the
fix_communities_creation_check
branch
from
d1a0df1
to
d4dcaab
Compare
Glignos
force-pushed
the
fix_communities_creation_check
branch
from
d4dcaab
to
22e12c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.