community items: accessibility & responsiveness improvements #948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kpsherva
reviewed
May 4, 2023
| const communityType = ui?.type?.title_l10n; | ||
|
|
||
| return ( | ||
| <Item | ||
| key={id} | ||
| className={`computer tablet only justify-space-between community-item ${itemClassName}`} | ||
| > | ||
| <Image as={Item.Image} size="tiny" src={links.logo} /> | ||
| <Image size="tiny" src={links.logo} alt="" /> |
There was a problem hiding this comment.
Suggested change
| <Image size="tiny" src={links.logo} alt="" /> | |
| <Image size="tiny" src={links.logo} alt={i18next.t("Community logo")} /> |
There was a problem hiding this comment.
I don't think this is needed, as the logo doesn't have any functionality and doesn't provide any information, ref https://www.w3.org/WAI/tutorials/images/
kpsherva
reviewed
May 4, 2023
...emantic-ui/js/invenio_communities/community/communitiesItems/CommunityCompactItemComputer.js
Outdated
Show resolved
Hide resolved
kpsherva
reviewed
May 4, 2023
...emantic-ui/js/invenio_communities/community/communitiesItems/CommunityCompactItemComputer.js
Outdated
Show resolved
Hide resolved
kpsherva
reviewed
May 4, 2023
.../semantic-ui/js/invenio_communities/community/communitiesItems/CommunityCompactItemMobile.js
Show resolved
Hide resolved
kpsherva
reviewed
May 4, 2023
...ssets/semantic-ui/js/invenio_communities/community/communitiesItems/CommunityItemComputer.js
Show resolved
Hide resolved
kpsherva
reviewed
May 4, 2023
.../assets/semantic-ui/js/invenio_communities/community/communitiesItems/CommunityItemMobile.js
Show resolved
Hide resolved
kpsherva
reviewed
May 4, 2023
| @@ -5,13 +5,17 @@ import { Label, Icon } from "semantic-ui-react"; | |||
| export const CommunityTypeLabel = ({ type }) => { | |||
| if (type === undefined) return null; | |||
| return ( | |||
| <Label size="tiny" className="primary"> | |||
| <Label size="small" horizontal className="primary"> | |||
There was a problem hiding this comment.
nit: its label horizontal by default?
There was a problem hiding this comment.
The horizontal prop gives it less padding on top/bottom (which makes it look less like a button), and adds right-margin.
vs
kpsherva
approved these changes
May 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes inveniosoftware/invenio-app-rdm#2182
Needs inveniosoftware/react-invenio-forms#199
showPermissionLabel-prop)