wip alembic: fix in transaction recipe #84
Conversation
dinosk
changed the title
dinosk
force-pushed
the
recipe-fix
branch
11 times, most recently
from
3512820
to
5778c68
Compare
| @@ -78,3 +81,11 @@ def create_alembic_version_table(): | |||
| alembic.migration_context._ensure_version_table() | |||
| for head in alembic.script_directory.revision_map._real_heads: | |||
| alembic.migration_context.stamp(alembic.script_directory, head) | |||
|
|
|||
|
|
|||
| def drop_alembic_version_table(): | |||
There was a problem hiding this comment.
Wouldn't it be useful if we also had a combined function drop_all() that does db.drop_all() and drop_alembic_version_table() so that we can use a single function from tests?
There was a problem hiding this comment.
We can do it yes but it would mean that it wouldn't be advised anymore to use sqlalchemy create_all and drop_all as they are not tested. Normally there is only one "alembic recipe" test per module and only that one need to do the extra step of dropping the alembic_version table.
Also the CLI commands invenio db create and invenio db drop are already creating and dropping the alembic_version table in addition to calling create_all and drop_all.
There was a problem hiding this comment.
Got it :-) No need to add the function then.
dinosk
force-pushed
the
recipe-fix
branch
6 times, most recently
from
4b978d2
to
56e5986
Compare
- Fixes creation of sequence in transaction table, so that it can be dropped. - Adds a utility function to drop the alembic_version table. Signed-off-by: Dinos Kousidis <konstantinos.kousidis@cern.ch>
Fixes creation of sequence in transaction table,
to make it able to drop
Adds a utility function to drop the alembic_version table
Closes #83
Signed-off-by: Dinos Kousidis konstantinos.kousidis@cern.ch