examples: fix deposit creation #171
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drjova
reviewed
Jul 10, 2017
| return super(Deposit, cls).create(data, id_=id_) | ||
| deposit = super(Deposit, cls).create(data, id_=id_) | ||
| # FIXME create the bucket! | ||
| deposit.files.bucket |
There was a problem hiding this comment.
I know... I put the FIXME to point out the problem. :)
There was a problem hiding this comment.
Do you have a suggestion for where to add it?
There was a problem hiding this comment.
Maybe in the FilesMixin?
The problem appeared when I tried to use the "vanilla" /deposit/new to create a new deposit.
These are the steps followed by the UI:
- Create the deposit with POST
- Read from the links the bucket endpoint
- Push the file to the bucket endpoint with PUT.
Without this "hack", the bucket is created when the deposit is serialized in JSON, i.e. after the session commit().
It means that the bucket doesn't exist anymore when the file is uploaded.
Maybe we should force the creation on deposit creation?
Something like:
class FilesMixin(object):
def create(self, *args, **kwargs):
self._create_bucket()
super(FilesMixin, self).create(*args, **kwargs)* Registers invenio-files-rest endpoints on example app. * Fixes url for creating the deposit, avoiding the HTTP redirection. * Disables JWT check on example app. * Adds bucket link on response after deposit creation. Signed-off-by: Leonardo Rossi <leonardo.r@cern.ch>
|
Closing PR because it's been stale for a long time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Registers invenio-files-rest endpoints on example app.
Fixes url for creating the deposit, avoiding the HTTP redirection.
Disables JWT check on example app.
Adds bucket link on response after deposit creation.
Signed-off-by: Leonardo Rossi leonardo.r@cern.ch