models: JSON-friendly errors in ensure_state #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jacopo Notarstefano <jacopo.notarstefano@gmail.com>
Turns out they weren't that hard, so I added a PoC for them. |
lnielsen
reviewed
Dec 7, 2017
| @@ -141,6 +141,32 @@ def inner(self, *args, **kwargs): | |||
| return decorator | |||
|
|
|||
|
|
|||
| class BucketError(object): | |||
There was a problem hiding this comment.
Should they not inherit from Exception?
There was a problem hiding this comment.
These two classes are patterned over https://github.com/inveniosoftware/invenio-rest/blob/d5a3d185c0a8c8cd46860bd0fd9be8bb3786f157/invenio_rest/errors.py#L35-L58, which also doesn't inherit from Exception, possibly because it's not intended to be thrown, but is just representing an error.
There was a problem hiding this comment.
...that said, I can absolutely change them if you think it's better!
lnielsen
reviewed
Dec 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #171, but I'm not fully convinced that this is the best solution for the problem as all those small classes looks a bit clunky. It's also missing tests as they seem tricky to write, and if this solution is not going in the right direction then it would have been a waste of effort...