cli: allow listing and setting default of locations #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix multiple defaults upon creation Co-authored-by: Werner Gresshoff <gressho@uni-muenster.de>
Co-authored-by: Werner Gresshoff <gressho@uni-muenster.de>
Closed
ppanero
changed the title
fenekku
reviewed
Feb 7, 2020
fenekku
reviewed
Feb 7, 2020
fenekku
approved these changes
Feb 10, 2020
|
Fails due to broken imports from Werkzeug (coming from bablex). |
fenekku
reviewed
Feb 11, 2020
lnielsen
reviewed
Feb 13, 2020
lnielsen
approved these changes
Feb 14, 2020
Yes, coming from:
I bumped the minor version in all. However, |
|
@lnielsen tests are passing :) |
|
All good on my side. I am not authorized to merge though; someone else will have to do it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
--defaultthere were two defaults in DB and therefore failing the uploading of files.Duplicated of #235 Since the PR was from master branch I could not force push to squash commits.
Slight refactoring to fixt tests. (@wgresshoff sorry I had to take out the pretty print it is a nice addition but it requires a bigger refactor along invenio).
Warning it is not backwards compatible:
locationcommand is now a group to contain its related commandscreate,listandset_default.Location.get_by_name()returns nowone_or_noneinstead ofoneand raising an exception if it does not exist.Requires
Closes #234
Closes #232