Basic file serving #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -157,10 +163,11 @@ def post(self, **kwargs): | |||
| args = parser.parse(self.post_args, request) | |||
| try: | |||
| if args['location_id']: | |||
| location = Location.get(args['location_id']) | |||
| # TODO: Check why query is used directly. | |||
| location = Location.query.get(args['location_id']) | |||
There was a problem hiding this comment.
Should I also rename args['location_id'] to 'location_name' or 'location'?
|
@drjova You can merge. Running to a meeting now :-) |
|
@ddaze could you please rebase :) |
|
I think you'll have to rebase again |
* Adds file serving tests. (addresses #15) * Replaces bucket `location_id` parameter with `location_name`. * Adds basic serialize function. * Adds objects test fixture. Signed-off-by: David Zerulla <ddaze@outlook.de>
|
okay 🚶 :D |
| assert resp.status_code == 200 | ||
|
|
||
|
|
||
| def test_post_bucket(app, dummy_location): |
There was a problem hiding this comment.
Do you really need the dummy_location here?
There was a problem hiding this comment.
Yes, without a location no bucket can be created.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.