global: adds permissions #34
Conversation
krzysztof
commented
Mar 3, 2016
krzysztof
commented
- Adds permissions to files REST.
| @@ -138,7 +138,7 @@ def test_post_bucket(app, dummy_location): | |||
| # def test_get_object_list(app, dummy_objects): | |||
|
|
|||
|
|
|||
| def test_get_object_get(app, objects): | |||
| def TODO_test_get_object_get(app, objects): | |||
There was a problem hiding this comment.
Unfortunately @ddaze we did double work as I also implemented some views tests (which also take permissions into account). I have the test test_get_object_get and test_get_object_get_404 temporarily. I will have to merge those views together, so the invenio_files_rest/test_permissions.py file will disappear on behalf of the views tests which will live here instead.
There was a problem hiding this comment.
Update: Merged tests from test_permissions.py into test_views.py
There was a problem hiding this comment.
No problem, I learned how it works by implementing it.
* Adds permissions to files REST Signed-off-by: Krzysztof Nowak <k.nowak@cern.ch>
| client.post(login_url, data=u2_data) | ||
| data = {'file': (BytesIO(b'contents2'), 'file.dat')} | ||
| resp = client.put(object_url, data=data, headers=headers) | ||
| assert resp.status_code == 403 |
There was a problem hiding this comment.
This test should be extended to test for valid PUT (i.e. assert resp.status_code == 200 and check if file is correct), but that's blocked by serialization feature: https://github.com/inveniosoftware/invenio-files-rest/blob/master/invenio_files_rest/views.py#L519
