cli: import from directory #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| def location(name, uri, default): | ||
| """Create new location.""" | ||
| from .models import Location | ||
| location = Location(name=name, uri=uri, default=default) |
There was a problem hiding this comment.
The previous default location should be unset. Perhaps implemented via a Location.create()?
There was a problem hiding this comment.
We can create an issue if somebody needs it otherwise I can remove the cli completely and keep only the helper function.
jirikuncar
force-pushed
the
cli-dir
branch
2 times, most recently
from
b38cb3c
to
54e6c96
Compare
| @click.argument('source', type=click.Path(exists=True, resolve_path=True)) | ||
| @click.option('--checksum/--no-checksum', default=False) | ||
| @with_appcontext | ||
| def bucket_from(source, checksum): |
There was a problem hiding this comment.
Would it perhaps make sense to split it in two commands into:
bucket(create a bucket)cp <source> <bucket, key?>(then we could later extend withcp <bucket, key?> <destination>as well ascp <src bucket, key> <dest bucket, key>) so we have basic upload/download cli.
I.e. basically imitating unix commands.
Signed-off-by: Jiri Kuncar <jiri.kuncar@cern.ch>
Signed-off-by: Jiri Kuncar <jiri.kuncar@cern.ch>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.