global: migrate zenodo github integration #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slint
changed the title
| @property | ||
| def doi(self): | ||
| if self.record: | ||
| return self.record.json.get('doi') |
There was a problem hiding this comment.
shall we use PID fetcher here?
slint
force-pushed
the
ui_migration
branch
3 times, most recently
from
75389aa
to
86d532c
Compare
* Fixes several test cases by supplying missing dependencies such as Flask-CORS for Invenio-REST and by moving work-in-progress imports under corresponding test functions. * Adds test database `test.db` to the git ignore list. * Completes the `AUTHORS.rst` author list. Signed-off-by: Tibor Simko <tibor.simko@cern.ch>
slint
force-pushed
the
ui_migration
branch
6 times, most recently
from
7cba5b7
to
f0384e8
Compare
| release_id=release_id, | ||
| ).first() | ||
| if existing_release: | ||
| msg = 'Release [{0}:{1}] has already been received with status {1}' |
There was a problem hiding this comment.
Shouldn't this be "Release [{0}:{1}] has already been received with status {2}"?
There was a problem hiding this comment.
What about using names instead of numbers for string formatting?
'Release [{tag}:{release_id}] ...: {status}.'.format(tag=..., release_id=..., ...)
slint
force-pushed
the
ui_migration
branch
15 times, most recently
from
6c2c229
to
6aa42b9
Compare
| if sync_hooks: | ||
| self._sync_hook(gh_repo) | ||
|
|
||
| self._sync_hooks(active_repos.keys(), async=async_hooks) |
There was a problem hiding this comment.
Are we sure that we want alway to force hooks syncing?
There was a problem hiding this comment.
Currently the hook sync behaviour goes as:
- Initial GitHub account connection OR Index page access after a full day without sync:
- Triggers an async task that does the hook syncing (hook syncing happens passively).
- User clicks on "Sync now..." button on index page:
- Triggers a synchronous hook sync through the AJAX request which updates the page on the spot (hook syncing happens on-demand).
There was a problem hiding this comment.
My question was more about keep the sync_hooks parameter so you can sync everything but hooks.
|
Changes Unknown when pulling 4e30a57 on slint:ui_migration into * on inveniosoftware:master*. |
|
|
||
| def _(text): | ||
| """Identity function for `gettext`.""" | ||
| # FIXME: Replace with `speaklater.make_lazy_gettext` |
There was a problem hiding this comment.
or better flask_babelex.lazy_gettext
* Fixes issue with current_webhooks only being available on API application by forcing GITHUB_WEBHOOK_RECEIVER_URL to be set. Signed-off-by: Lars Holm Nielsen <lars.holm.nielsen@cern.ch>
Signed-off-by: Lars Holm Nielsen <lars.holm.nielsen@cern.ch>
| @@ -331,31 +321,29 @@ def repository(self): | |||
| """Return repository metadata.""" | |||
| return self.payload['repository'] | |||
|
|
|||
| @property | |||
| def repository_model(self): | |||
| @cached_property | |||
There was a problem hiding this comment.
This might be dangerous because you can get an object bounded to a different session or transaction ...
* Handles OAuth signals for account setup and hook syncing. * Adds a default OAuth remote application configuration. Signed-off-by: Alexander Ioannidis <a.ioannidis@cern.ch> Signed-off-by: Lars Holm Nielsen <lars.holm.nielsen@cern.ch>
* Adds proper documentation. * Refactors Repository model's get and create methods. * Adds custom exceptions. * Remove unused static files. Signed-off-by: Alexander Ioannidis <a.ioannidis@cern.ch>
slint
force-pushed
the
ui_migration
branch
2 times, most recently
from
7bf2984
to
66a8f84
Compare
* Reduces remote GitHub API calls. * Migrates methods from Release model to GitHubRelease. * Uses PID Fetcher for Release records. * Integrates GitHubRelease in views. * Adds exception handling and proper HTTP status code responses. Signed-off-by: Alexander Ioannidis <a.ioannidis@cern.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alexander Ioannidis a.ioannidis@cern.ch