Add language dropdown selector #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
andrewm89
commented
Nov 18, 2016
andrewm89
commented
- addresses templates: language selector dropdown #40
|
@andrewm89 thanks! The code looks good. Can you amend commit message so it follows the inveniosoftware style or shall I amend it during squash&merge? |
andrewm89
force-pushed
the
andrewm/rfc_40/language-selector
branch
from
543682b
to
bf2faf8
Compare
|
@jirikuncar is it ok now? |
|
@andrewm89 almost :) |
* Add language dropdown selector (addresses #40) Signed-off-by: Andrew McCracken <andrew@tind.io>
andrewm89
force-pushed
the
andrewm/rfc_40/language-selector
branch
from
bf2faf8
to
12a8fae
Compare
|
@jirikuncar third time lucky |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.