macros: language selector fixes #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lnielsen
force-pushed
the
selectorfix
branch
from
e1d49fd
to
4dc53b2
Compare
jirikuncar
reviewed
Feb 14, 2017
| @@ -22,4 +22,4 @@ msgstr "" | |||
| #: invenio_i18n/templates/invenio_i18n/macros/language_selector.html:31 | |||
| #: invenio_i18n/templates/invenio_i18n/macros/language_selector.html:41 | |||
| msgid "Language:" | |||
| msgstr "" | |||
| msgstr "Sprog:" | |||
There was a problem hiding this comment.
Have you pushed it to Transifex? Nobody should update PO files locally, but instead run tx pull -l da after editing online.
--
See https://www.transifex.com/inveniosoftware/invenio/translate/#da/invenio-i18n-messages/95780369
There was a problem hiding this comment.
Now pulled from transifex.
lnielsen
force-pushed
the
selectorfix
branch
from
4dc53b2
to
3de4303
Compare
* Fixes language selectors which where wrongly using I18N_LANGUAGES configuration variable instead of current_i18n.get_locales() to iterate over languages. * Fixes language selectors to display the language title in the locale language. * Adds clarification to documentation on how to properly configure languages for Invenio-I18N. Signed-off-by: Lars Holm Nielsen <lars.holm.nielsen@cern.ch>
lnielsen
force-pushed
the
selectorfix
branch
from
3de4303
to
8ee556a
Compare
* Pulls latest translations from Transifex. Signed-off-by: Lars Holm Nielsen <lars.holm.nielsen@cern.ch>
lnielsen
force-pushed
the
selectorfix
branch
from
8ee556a
to
cca2195
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes language selectors which where wrongly using I18N_LANGUAGES
configuration variable instead of current_i18n.get_locales() to
iterate over languages.
Fixes language selectors to display the language title in the locale
language.
Adds clarification to documentation on how to properly configure
languages for Invenio-I18N.
Signed-off-by: Lars Holm Nielsen lars.holm.nielsen@cern.ch