global: doc_type and signals #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jirikuncar
force-pushed
the
signal-processor
branch
2 times, most recently
from
34a383e
to
6f2d7c2
Compare
| class Producer(KombuProducer): | ||
| """Producer validating published messages.""" | ||
|
|
||
| def publish(self, data, **kwargs): |
There was a problem hiding this comment.
Would it perhaps be better force the signature to publish(id, op, index, doctype) to make the API more rigid? Just thinking that if we expose the create_producer() as part of the API, then there's quite a chance to pass something wrong into the queue.
|
Add a |
* Moves signal handler for `models_commited` from Invenio-Search. (closes inveniosoftware#1) Signed-off-by: Jiri Kuncar <jiri.kuncar@cern.ch>
jirikuncar
force-pushed
the
signal-processor
branch
from
6f2d7c2
to
9bb3289
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jiri Kuncar jiri.kuncar@cern.ch