tests: RabbitMQ as a default BROKER_URL #41
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -50,7 +50,7 @@ def app(request): | |||
| instance_path = tempfile.mkdtemp() | |||
| app = Flask('testapp', instance_path=instance_path) | |||
| app.config.update( | |||
| BROKER_URL=os.environ.get('BROKER_URL', 'memory://'), | |||
There was a problem hiding this comment.
Can you just change the default value so one can still test with different brokers?
jirikuncar
changed the title
|
@nharraud WDYT about new PR title as commit title? |
|
I would just specify in the title that it is only for the tests. |
nharraud
force-pushed
the
fix-test-queue
branch
from
223e3cd
to
fdd9be2
Compare
|
it's clear from the component name ;) |
|
@jirikuncar you're right. Fixing it. |
* FIX Fixes tests by using rabbitmq instead of in memory queue. (closes inveniosoftware#40) Signed-off-by: Nicolas Harraudeau <nicolas.harraudeau@cern.ch>
nharraud
force-pushed
the
fix-test-queue
branch
from
fdd9be2
to
b8e2661
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(closes tests: conflict between CliRunner and Celery in memory broker #40)
Signed-off-by: Nicolas Harraudeau nicolas.harraudeau@cern.ch