travis: elasticsearch v5 support #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lnielsen
changed the title
lnielsen
changed the title
lnielsen
changed the title
slint
approved these changes
Dec 1, 2017
.travis.yml
Outdated
| - "mkdir /tmp/elasticsearch" | ||
| - "wget -O - $ES_URL | tar xz --directory=/tmp/elasticsearch --strip-components=1" | ||
| - "/tmp/elasticsearch/bin/elasticsearch &" | ||
| - "sleep 20" | ||
| - "travis_retry pip install --upgrade pip setuptools py" | ||
| - "travis_retry pip install twine wheel coveralls requirements-builder" | ||
| - "requirements-builder -e all --level=min setup.py > .travis-lowest-requirements.txt" |
There was a problem hiding this comment.
Shouldn't it be "requirements-builder -e all -e $EXTRAS --level=min setup.py > .travis-lowest-requirements.txt"
| "testrecord-v1.0.0": { | ||
| "properties": { | ||
| "control_number": { | ||
| "type": "string" |
There was a problem hiding this comment.
This is ok with ES5, but fires a warning. I'm not sure if we should explicitly change ES5 mappings to use the correct field type for string (text, unless there was a index: not_analyzed, in which case it should be keyword)
setup.py
Outdated
| @@ -45,13 +45,21 @@ | |||
| 'redis>=2.10.0', | |||
| ] | |||
|
|
|||
| invenio_search_version = '1.0.0b2' | |||
There was a problem hiding this comment.
1.0.0b3 when inveniosoftware/invenio-search#123 is merged
nharraud
reviewed
Dec 1, 2017
| "testrecord-v1.0.0": { | ||
| "properties": { | ||
| "control_number": { | ||
| "type": "string" |
nharraud
reviewed
Dec 1, 2017
| "type": "string" | ||
| }, | ||
| "description": { | ||
| "type": "string" |
nharraud
reviewed
Dec 1, 2017
| "type": "long" | ||
| }, | ||
| "title": { | ||
| "type": "string", |
nharraud
reviewed
Dec 1, 2017
| "copy_to": "suggest_title" | ||
| }, | ||
| "type": { | ||
| "type": "string" |
|
@lnielsen FYI, I pushed a fix for the failing builds (the bulk index queue needed to be initialized in the doctests before sending records for bulk indexing) |
slint
force-pushed
the
es5
branch
3 times, most recently
from
87e72c5
to
e00a57f
Compare
* Moves mappings into v2/v5 subdirectories. * Extends travis with v2/v5 versions. * Moves invenio-search to extra dependencies with support for ES 2/5.
* Removes automatic indexing on models_committed signal since this method does not allow enough control over the indexing process and the method will have unintended side effects if enabled with modules that are unaware of the signal being install. Controllers should instead explicitly index records when needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.