Skip to content

Commit

Permalink
jobs: fixed config and formatting
Browse files Browse the repository at this point in the history
  • Loading branch information
0einstein0 committed May 30, 2024
1 parent d126509 commit 4d19a99
Show file tree
Hide file tree
Showing 2 changed files with 37 additions and 28 deletions.
36 changes: 20 additions & 16 deletions invenio_jobs/administration/jobs.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,11 @@

"""Invenio administration view module."""

from invenio_administration.views.base import AdminResourceListView, AdminResourceEditView, AdminResourceDetailView, AdminResourceCreateView
from invenio_administration.views.base import (
AdminResourceListView,
AdminResourceEditView,
AdminResourceCreateView,
)
from invenio_i18n import lazy_gettext as _


Expand Down Expand Up @@ -44,7 +48,7 @@ class JobsListView(AdminResourceListView):
search_facets_config_name = "JOBS_FACETS"


class JobsDetailsView(AdminResourceDetailView):
class JobsDetailsView(AdminResourceListView):
"""Configuration for Jobs detail view which shows runs."""

def get_api_endpoint(self, pid_value=None):
Expand Down Expand Up @@ -79,6 +83,7 @@ def get_api_endpoint(self, pid_value=None):
search_sort_config_name = "JOBS_SORT_OPTIONS"
search_facets_config_name = "JOBS_FACETS"


class JobsEditView(AdminResourceEditView):
"""Configuration for job edit view."""

Expand All @@ -91,18 +96,18 @@ class JobsEditView(AdminResourceEditView):
list_view_name = "jobs"

form_fields = {
"title": {
"order": 1,
"text": _("Title"),
"description": _("A title of the job."),
},
"description": {
"order": 2,
"text": _("Description"),
"description": _("A short description about the job."),
},
"created": {"order": 5},
"updated": {"order": 6},
"title": {
"order": 1,
"text": _("Title"),
"description": _("A title of the job."),
},
"description": {
"order": 2,
"text": _("Description"),
"description": _("A short description about the job."),
},
"created": {"order": 5},
"updated": {"order": 6},
}


Expand All @@ -116,7 +121,7 @@ class JobsCreateView(AdminResourceCreateView):
api_endpoint = "/jobs"
title = "Create Job"
list_view_name = "jobs"

form_fields = {
"title": {
"order": 1,
Expand All @@ -131,4 +136,3 @@ class JobsCreateView(AdminResourceCreateView):
"created": {"order": 3},
"updated": {"order": 4},
}

Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ import { http } from "react-invenio-forms";

class SearchResultItemComponent extends Component {
render() {
const {
const {
title,

Check failure on line 25 in invenio_jobs/assets/semantic-ui/js/invenio_jobs/administration/search/JobSearchResultItemLayout.js

View workflow job for this annotation

GitHub Actions / Tests (3.9, postgresql14, opensearch2, 18.x)

'title' is missing in props validation

Check failure on line 25 in invenio_jobs/assets/semantic-ui/js/invenio_jobs/administration/search/JobSearchResultItemLayout.js

View workflow job for this annotation

GitHub Actions / Tests (3.9, postgresql14, opensearch2, 20.x)

'title' is missing in props validation

Check failure on line 25 in invenio_jobs/assets/semantic-ui/js/invenio_jobs/administration/search/JobSearchResultItemLayout.js

View workflow job for this annotation

GitHub Actions / Tests (3.12, postgresql14, opensearch2, 18.x)

'title' is missing in props validation

Check failure on line 25 in invenio_jobs/assets/semantic-ui/js/invenio_jobs/administration/search/JobSearchResultItemLayout.js

View workflow job for this annotation

GitHub Actions / Tests (3.12, postgresql14, opensearch2, 20.x)

'title' is missing in props validation
actions,

Check failure on line 26 in invenio_jobs/assets/semantic-ui/js/invenio_jobs/administration/search/JobSearchResultItemLayout.js

View workflow job for this annotation

GitHub Actions / Tests (3.9, postgresql14, opensearch2, 18.x)

'actions' is missing in props validation

Check failure on line 26 in invenio_jobs/assets/semantic-ui/js/invenio_jobs/administration/search/JobSearchResultItemLayout.js

View workflow job for this annotation

GitHub Actions / Tests (3.9, postgresql14, opensearch2, 20.x)

'actions' is missing in props validation

Check failure on line 26 in invenio_jobs/assets/semantic-ui/js/invenio_jobs/administration/search/JobSearchResultItemLayout.js

View workflow job for this annotation

GitHub Actions / Tests (3.12, postgresql14, opensearch2, 18.x)

'actions' is missing in props validation

Check failure on line 26 in invenio_jobs/assets/semantic-ui/js/invenio_jobs/administration/search/JobSearchResultItemLayout.js

View workflow job for this annotation

GitHub Actions / Tests (3.12, postgresql14, opensearch2, 20.x)

'actions' is missing in props validation
apiEndpoint,

Check failure on line 27 in invenio_jobs/assets/semantic-ui/js/invenio_jobs/administration/search/JobSearchResultItemLayout.js

View workflow job for this annotation

GitHub Actions / Tests (3.9, postgresql14, opensearch2, 18.x)

'apiEndpoint' is missing in props validation

Check failure on line 27 in invenio_jobs/assets/semantic-ui/js/invenio_jobs/administration/search/JobSearchResultItemLayout.js

View workflow job for this annotation

GitHub Actions / Tests (3.9, postgresql14, opensearch2, 20.x)

'apiEndpoint' is missing in props validation

Check failure on line 27 in invenio_jobs/assets/semantic-ui/js/invenio_jobs/administration/search/JobSearchResultItemLayout.js

View workflow job for this annotation

GitHub Actions / Tests (3.12, postgresql14, opensearch2, 18.x)

'apiEndpoint' is missing in props validation

Check failure on line 27 in invenio_jobs/assets/semantic-ui/js/invenio_jobs/administration/search/JobSearchResultItemLayout.js

View workflow job for this annotation

GitHub Actions / Tests (3.12, postgresql14, opensearch2, 20.x)

'apiEndpoint' is missing in props validation
Expand All @@ -30,7 +30,8 @@ class SearchResultItemComponent extends Component {
resourceName,

Check failure on line 30 in invenio_jobs/assets/semantic-ui/js/invenio_jobs/administration/search/JobSearchResultItemLayout.js

View workflow job for this annotation

GitHub Actions / Tests (3.9, postgresql14, opensearch2, 18.x)

'resourceName' is missing in props validation

Check failure on line 30 in invenio_jobs/assets/semantic-ui/js/invenio_jobs/administration/search/JobSearchResultItemLayout.js

View workflow job for this annotation

GitHub Actions / Tests (3.9, postgresql14, opensearch2, 20.x)

'resourceName' is missing in props validation

Check failure on line 30 in invenio_jobs/assets/semantic-ui/js/invenio_jobs/administration/search/JobSearchResultItemLayout.js

View workflow job for this annotation

GitHub Actions / Tests (3.12, postgresql14, opensearch2, 18.x)

'resourceName' is missing in props validation

Check failure on line 30 in invenio_jobs/assets/semantic-ui/js/invenio_jobs/administration/search/JobSearchResultItemLayout.js

View workflow job for this annotation

GitHub Actions / Tests (3.12, postgresql14, opensearch2, 20.x)

'resourceName' is missing in props validation
displayDelete,

Check failure on line 31 in invenio_jobs/assets/semantic-ui/js/invenio_jobs/administration/search/JobSearchResultItemLayout.js

View workflow job for this annotation

GitHub Actions / Tests (3.9, postgresql14, opensearch2, 18.x)

'displayDelete' is missing in props validation

Check failure on line 31 in invenio_jobs/assets/semantic-ui/js/invenio_jobs/administration/search/JobSearchResultItemLayout.js

View workflow job for this annotation

GitHub Actions / Tests (3.9, postgresql14, opensearch2, 20.x)

'displayDelete' is missing in props validation

Check failure on line 31 in invenio_jobs/assets/semantic-ui/js/invenio_jobs/administration/search/JobSearchResultItemLayout.js

View workflow job for this annotation

GitHub Actions / Tests (3.12, postgresql14, opensearch2, 18.x)

'displayDelete' is missing in props validation

Check failure on line 31 in invenio_jobs/assets/semantic-ui/js/invenio_jobs/administration/search/JobSearchResultItemLayout.js

View workflow job for this annotation

GitHub Actions / Tests (3.12, postgresql14, opensearch2, 20.x)

'displayDelete' is missing in props validation
displayEdit,

Check failure on line 32 in invenio_jobs/assets/semantic-ui/js/invenio_jobs/administration/search/JobSearchResultItemLayout.js

View workflow job for this annotation

GitHub Actions / Tests (3.9, postgresql14, opensearch2, 18.x)

'displayEdit' is missing in props validation

Check failure on line 32 in invenio_jobs/assets/semantic-ui/js/invenio_jobs/administration/search/JobSearchResultItemLayout.js

View workflow job for this annotation

GitHub Actions / Tests (3.9, postgresql14, opensearch2, 20.x)

'displayEdit' is missing in props validation

Check failure on line 32 in invenio_jobs/assets/semantic-ui/js/invenio_jobs/administration/search/JobSearchResultItemLayout.js

View workflow job for this annotation

GitHub Actions / Tests (3.12, postgresql14, opensearch2, 18.x)

'displayEdit' is missing in props validation

Check failure on line 32 in invenio_jobs/assets/semantic-ui/js/invenio_jobs/administration/search/JobSearchResultItemLayout.js

View workflow job for this annotation

GitHub Actions / Tests (3.12, postgresql14, opensearch2, 20.x)

'displayEdit' is missing in props validation
result } = this.props;
result,
} = this.props;

return (
<Table.Row>
Expand Down Expand Up @@ -107,20 +108,24 @@ class SearchResultItemComponent extends Component {
<Button.Group size="tiny" className="relaxed">
{/* <RunButton config={result.default_args} /> */}
<Button
icon
labelPosition="left"
onClick={() => {
http.post("/api/jobs/" + result.id + "/runs");
}}
>
<Icon name="play" />
Run
</Button>
icon
labelPosition="left"
onClick={() => {
http.post("/api/jobs/" + result.id + "/runs");
}}
>
<Icon name="play" />
Run
</Button>
<Actions
title={title}
resourceName={resourceName}
apiEndpoint={apiEndpoint}
editUrl={AdminUIRoutes.editView(listUIEndpoint, result, idKeyPath)}
editUrl={AdminUIRoutes.editView(
listUIEndpoint,
result,
idKeyPath
)}
actions={actions}
displayEdit={displayEdit}
displayDelete={displayDelete}
Expand Down

0 comments on commit 4d19a99

Please sign in to comment.