Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

errors: fix string interpolation and release #101

Merged
merged 2 commits into from
Jun 17, 2021
Merged

errors: fix string interpolation and release #101

merged 2 commits into from
Jun 17, 2021

Conversation

ppanero
Copy link
Member

@ppanero ppanero commented Jun 16, 2021

It was being displayed wrongly, e.g.:

 invenio_jsonschemas.errors.JSONSchemaDuplicate: Schema "{schema}" defined in multiple directories: "/Users/ppanero/Workspace/inveniosw/invenio-vocabularies/invenio_vocabularies/records/jsonschemas" and "/Users/ppanero/Workspace/inveniosw/invenio-vocabularies/invenio_vocabularies/records/jsonschemas"

Now it displays the correct value (not the variable name):

  invenio_jsonschemas.errors.JSONSchemaDuplicate: Schema vocabularies/vocabulary-v1.0.0.json defined in multiple directories: /Users/ppanero/Workspace/inveniosw/invenio-vocabularies/invenio_vocabularies/records/jsonschemas and /Users/ppanero/Workspace/inveniosw/invenio-vocabularies/invenio_vocabularies/records/jsonschemas

@ppanero ppanero added this to Triage in InvenioRDM June Team QA via automation Jun 16, 2021
@ppanero ppanero moved this from Triage to Pending review in InvenioRDM June Team QA Jun 16, 2021
@fenekku fenekku moved this from Pending review to In review in InvenioRDM June Team QA Jun 17, 2021
@fenekku fenekku self-assigned this Jun 17, 2021
fenekku
fenekku approved these changes Jun 17, 2021
View reviewed changes
Copy link

@fenekku fenekku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we need to support Python 3.5 and below even though Python 3.5 is not officially supported anymore, we can skip those.

invenio_jsonschemas/errors.py Show resolved Hide resolved
invenio_jsonschemas/errors.py Show resolved Hide resolved
@fenekku fenekku assigned ppanero and unassigned fenekku Jun 17, 2021
@ppanero ppanero merged commit 1818e25 into inveniosoftware:master Jun 17, 2021
InvenioRDM June Team QA automation moved this from In review to Done Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fenekku fenekku fenekku approved these changes

Assignees

@ppanero ppanero

Labels
None yet
Projects
No open projects
InvenioRDM June Team QA
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ppanero @fenekku