-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
config: url scheme configuration addition #41
Conversation
app.config['JSONSCHEMAS_URL_SCHEME'] = url_scheme | ||
else: | ||
# test with default url scheme configuration | ||
url_scheme = 'http' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
from invenio_jsonschemas.config import JSONSCHEMAS_URL_SCHEME
url_scheme = JSONSCHEMAS_URL_SCHEME
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
87ba3d6
to
c948e3b
Compare
@jirikuncar any idea? :)
|
@jirikuncar if I invert the order of pytest and sphinx, it works! |
@hachreak I suspect the example tests. Can you check if it passes if you remove them? |
yes, it's the example app. I already tried. |
@jirikuncar do you have any clue to resolve the issue about test example app? Because I have a pending PR on CDS that requires this change. |
@hachreak my proposal was to use another virtualenv for example app testing. |
what do you mean exactly? O.o |
Signed-off-by: Leonardo Rossi <leonardo.r@cern.ch>
Signed-off-by: Leonardo Rossi <leonardo.r@cern.ch>
Signed-off-by: Leonardo Rossi <leonardo.r@cern.ch>
f70b5f9
to
a47c506
Compare
@jirikuncar I resolved the problem! :) |
@@ -29,3 +29,6 @@ | |||
|
|||
JSONSCHEMAS_ENDPOINT = '/schemas' | |||
"""Default schema endpoint.""" | |||
|
|||
JSONSCHEMAS_URL_SCHEME = 'http' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this by default not be https
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I set http
just for back-compatibility.
But, yes, maybe should be https
Signed-off-by: Leonardo Rossi leonardo.r@cern.ch