Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: url scheme configuration addition #41

Merged
merged 3 commits into from
Oct 10, 2016

Conversation

hachreak
Copy link
Member

@hachreak hachreak commented Oct 5, 2016

Signed-off-by: Leonardo Rossi leonardo.r@cern.ch

@hachreak hachreak self-assigned this Oct 5, 2016
app.config['JSONSCHEMAS_URL_SCHEME'] = url_scheme
else:
# test with default url scheme configuration
url_scheme = 'http'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from invenio_jsonschemas.config import JSONSCHEMAS_URL_SCHEME
url_scheme = JSONSCHEMAS_URL_SCHEME

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@hachreak
Copy link
Member Author

hachreak commented Oct 6, 2016

@jirikuncar any idea? :)

Warning, treated as error:

/home/travis/build/inveniosoftware/invenio-jsonschemas/docs/api.rst:28: WARNING: autodoc: failed to import module u'invenio_jsonschemas.ext'; the following exception was raised:

Traceback (most recent call last):

  File "/home/travis/virtualenv/python2.7.9/lib/python2.7/site-packages/sphinx/ext/autodoc.py", line 519, in import_object

    __import__(self.modname)

ImportError: No module named invenio_jsonschemas.ext

@hachreak
Copy link
Member Author

hachreak commented Oct 7, 2016

@jirikuncar if I invert the order of pytest and sphinx, it works!
I have no idea why because tests clean everything.
Note: the error happens only on travis!

@jirikuncar
Copy link
Member

@hachreak I suspect the example tests. Can you check if it passes if you remove them?

@hachreak
Copy link
Member Author

hachreak commented Oct 7, 2016

yes, it's the example app. I already tried.
And you can see also in travis that current master fails.

@hachreak
Copy link
Member Author

hachreak commented Oct 7, 2016

@jirikuncar do you have any clue to resolve the issue about test example app? Because I have a pending PR on CDS that requires this change.
could we simply run before sphinx and then the tests?

@jirikuncar
Copy link
Member

@hachreak my proposal was to use another virtualenv for example app testing.

@hachreak
Copy link
Member Author

hachreak commented Oct 7, 2016

what do you mean exactly? O.o
it looks complicated.. XD

Leonardo Rossi added 3 commits October 10, 2016 10:14
Signed-off-by: Leonardo Rossi <leonardo.r@cern.ch>
Signed-off-by: Leonardo Rossi <leonardo.r@cern.ch>
Signed-off-by: Leonardo Rossi <leonardo.r@cern.ch>
@hachreak
Copy link
Member Author

@jirikuncar I resolved the problem! :)
could you :shipit: now?

@jirikuncar jirikuncar merged commit a47c506 into inveniosoftware:master Oct 10, 2016
@@ -29,3 +29,6 @@

JSONSCHEMAS_ENDPOINT = '/schemas'
"""Default schema endpoint."""

JSONSCHEMAS_URL_SCHEME = 'http'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this by default not be https?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I set http just for back-compatibility.
But, yes, maybe should be https

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants