Fixing issue #85 - resolve_schema: allOf inside allOf is ignored #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 18, 2020 13:52
|
Thanks a lot for contributing the fix. Do you have an example schema that fails on the current method, and is being fixed by this PR. Then I can try to add a tests to the PR, to make sure it works in the future as well. |
|
@Glignos added such a schema to a test and checked that the fix makes it pass. I think he's pushing the test soon |
|
Superseded by #94 |
|
Closed by #94 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reordered pop for allOf to fix #85