examples: fix for example instructions #11
Conversation
switowski
commented
Feb 29, 2016
switowski
commented
- FIX Updates the app.py installation instructions
switowski
force-pushed
the
example-app-fix
branch
2 times, most recently
from
1ac7b9f
to
9f56c13
Compare
| pip install -e .[all] | ||
| pip install invenio-theme==1.0.0a9 | ||
| pip install -r requirements-devel.txt |
There was a problem hiding this comment.
The only thing that requirements-devel.txt installs is DoJSON, why not put it here directly?
Alternatively you can create examples/requirements.txt if you wan to make the instructions smaller.
There was a problem hiding this comment.
FWIW I like examples/requirements-devel.txt approach for consistency with the other Invenio packages. And I would mention it with the "# optional" comment, so that the instructions would be valid also in the future when we'll release dojson on PyPI.
switowski
force-pushed
the
example-app-fix
branch
from
9f56c13
to
a78c7da
Compare
* FIX Updates the app.py installation instructions
switowski
force-pushed
the
example-app-fix
branch
from
a78c7da
to
809f973
Compare
| pip install -e .[all] | ||
| pip install invenio-theme==1.0.0a9 | ||
| pip install git+git://github.com/inveniosoftware/dojson.git |
There was a problem hiding this comment.
Shouldn't this be pip install dojson
There was a problem hiding this comment.
It should but after the new version of dojson is released (the current released version is missing some cli functions) :/
There was a problem hiding this comment.
Is it possible to make a release of dojson as-is, and then merge this afterwards? It's just that usually these tiny updates after something else is released are forgotten.
| @@ -1,30 +0,0 @@ | |||
| # -*- coding: utf-8 -*- | |||
There was a problem hiding this comment.
It's good idea to keep this file here.
|
I'm closing this PR as the #17 is a further improvement of it. |
