cli: more loading refactoring #53
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| """Common helper function for load simple objects. | ||
|
|
||
| Note: Extra `args` and `kwargs` are passed to the `load_task` function. | ||
| NOTE: `task_args` and `task_kwargs` are passed to the `load_task` |
There was a problem hiding this comment.
could you use .. note:: instead of NOTE:? :)
See also line 154.
* Adds option for single-record loading to generic loader method. Signed-off-by: Krzysztof Nowak <k.nowak@cern.ch>
|
Can you rebase? |
|
@lnielsen It's rebased, the "cli refactoring" commit is a different refactoring, I intended to have two in previous commit but somehow it got merged before. |
* Missing user IDs are now handled by setting them as null on the SIP. Signed-off-by: Krzysztof Nowak <k.nowak@cern.ch>
|
Branch is still out of date. |
|
Spooky stuff happened with this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Krzysztof Nowak k.nowak@cern.ch