Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add encoding support #51

Merged
merged 1 commit into from Jan 11, 2018
Merged

feat: add encoding support #51

merged 1 commit into from Jan 11, 2018

Conversation

jma
Copy link
Contributor

@jma jma commented Dec 7, 2017

Signed-off-by: Johnny Mariéthoz Johnny.Mariethoz@rero.ch

@jma
Copy link
Contributor Author

jma commented Dec 7, 2017

isort failed on travis but works nice on my machine. Any ideas?

@jacquerie
Copy link
Contributor

isort failed on travis but works nice on my machine. Any ideas?

Two ideas:

  1. Make sure that the version of isort matches.
  2. Make sure that you're installing exactly the same packages, as isort will report different things on where an import should be if the package is not installed.

@jacquerie
Copy link
Contributor

It's probably 2., given that it's complaining about invenio_db, and you don't install it in the all extra (but you install it by choosing which DB backend to use, e.g. $ pip install -e .[all,sqlite3].)

@jma jma force-pushed the rero-encoding-support branch 2 times, most recently from e913d16 to 47cc982 Compare December 7, 2017 13:56
@jma
Copy link
Contributor Author

jma commented Dec 7, 2017

You are right: isort version matches, thus it is 2!
But invenio-db is installed...
I created a virtualenv from scratch and follows the travis steps and solved isort errors. I hope it will works!

@jma jma force-pushed the rero-encoding-support branch 2 times, most recently from aa32f30 to a71fa5c Compare December 7, 2017 14:31
@jma
Copy link
Contributor Author

jma commented Dec 7, 2017

Seems ok.

@jma
Copy link
Contributor Author

jma commented Dec 18, 2017

Any news?

@jacquerie
Copy link
Contributor

I just noticed a question of which I happened to know the answer to, @david-caro is probably the person who should be looking at this.

@jma jma requested a review from david-caro December 18, 2017 09:42
@david-caro david-caro self-assigned this Jan 8, 2018
@david-caro
Copy link
Member

Looks good to me :), thanks for the PR!

@jma @david-caro
global: add support to force encoding
e4d3311 
This allows to override the encoding provided by the server.

Signed-off-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
Signed-off-by: David Caro <david@dcaro.es>
@david-caro david-caro merged commit a4a2b54 into inveniosoftware:master Jan 11, 2018
@david-caro
Copy link
Member

david-caro commented Jan 11, 2018 •
edited

@jma Do you need this feature? I can do a release if that helps.

@jma
Copy link
Contributor Author

jma commented Mar 10, 2018

@david-caro Yes, it is require for RERO DOC. Thanks for the merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david-caro david-caro david-caro approved these changes

Assignees

@david-caro david-caro

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jma @jacquerie @david-caro