-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: include Elasticsearch 5 in Travis-CI #132
Conversation
6cd98a1
to
2ae4657
Compare
e21936f
to
a031868
Compare
ES5 tests in Travis are failing but I think otherwise the tasks defined in #103 are done, so I guess this is ready for review? If the reviewer has knowledge about |
Please note that files https://github.com/inveniosoftware/invenio/blob/master/scripts/provision-elasticsearch.sh and https://github.com/inveniosoftware/invenio/blob/master/elasticsearch/Dockerfile should probably be prepared for ES5. Maybe something like this could be used in
Also note that mapper-attachment -plugin is deprecated in ES5 in favor of ingest-attachment -plugin and that name of the binary that is used to install plugins changes in ES5 as well ( https://www.elastic.co/guide/en/elasticsearch/plugins/5.6/mapper-attachments.html |
3df5d09
to
7260991
Compare
The current state of this PR does not enable to support elasticsearch 5.
Currently invenio-search uses all the mappings provided. However if we want to support both elasticsearch-5 and elasticsearch-2 we would need to provide two different set of mappings. Thus we would need to refactor invenio-search. @inveniosoftware/architects Another issue pointed out by @slint : Elasticsearch version 2 End Of Life is 2018-02-28. We might want to go for version 5 or 6 immediately and drop version 2. |
There's also an official migration helper plugin that goes over some basic checks of the cluster. I've added the output of running the tool on the relevant issue #103 |
7260991
to
9273742
Compare
8a3dbf7
to
ffe3dfb
Compare
invenio_oaiserver/percolator.py
Outdated
from invenio_indexer.api import RecordIndexer | ||
from invenio_search import current_search, current_search_client | ||
|
||
from .models import OAISet | ||
from .proxies import current_oaiserver | ||
from .query import query_string_parser | ||
|
||
# ES5 percolator | ||
PERCROLATOR_DOC_TYPE = '.percolators' if ES_VERSION[0] == 2 else 'percolators' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PERCROLATOR
-> PERCOLATOR
ffe3dfb
to
8dee83b
Compare
* include Elasticsearch5 in Travis-CI tests. Signed-off-by: Harri Hirvonsalo <harri.hirvonsalo@cern.ch>
f387a5c
to
c71f4ee
Compare
c71f4ee
to
9870c61
Compare
Signed-off-by: Alexander Ioannidis <a.ioannidis@cern.ch> Co-authored-by: Harri Hirvonsalo <harri.hirvonsalo@cern.ch>
416c77b
to
2470c35
Compare
2470c35
to
051e8f4
Compare
Signed-off-by: Harri Hirvonsalo harri.hirvonsalo@cern.ch